Skip to content

chore: sync rm_set_option with mathlib, fix it on Windows, remove 29 respectTransparency options - #1705

Merged
zhikaip merged 3 commits into
masterfrom
update_rm_set_option
Oct 1, 2026
Merged

zhikaip merged 3 commits into
masterfrom
update_rm_set_option

Conversation

@zhikaip

@zhikaip zhikaip commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

This PR updates the set_option removal script and runs it across the repo.

Commits

  1. chore(scripts): sync rm_set_option.py and set_option_utils.py with mathlib. Brings in mathlib4#41997:

    • The script now leaves a set_option line alone if the line above is a -- comment or ends in -/.
    • backward.isDefEq.respectTransparency.types is added to the default options.
  2. fix(scripts): kill timed-out builds on Windows in dag_traversal.py. os.killpg doesn't exist on Windows, so the first per-module timeout crashed the script and left the build running. A new _kill_tree helper falls back to taskkill /F /T. This is a local change to a file copied from mathlib; I plan to send it upstream too.

  3. chore: remove unnecessary set_option backward.isDefEq.respectTransparency false. The script's results: 29 lines removed in 8 files.

    File Removed
    Relativity/PauliMatrices/ToTensor.lean 15
    SpaceAndTime/SpaceTime/Basic.lean 6
    Relativity/Special/TwinParadox/Basic.lean 3
    Electromagnetism/Distributional/Dynamics/IsExtrema.lean 1
    Electromagnetism/Distributional/FieldStrength.lean 1
    Relativity/LorentzGroup/Boosts/Generalized.lean 1
    Relativity/LorentzGroup/Rotations.lean 1
    QuantumInfo/Entropy/VonNeumann.lean 1

No lemmas or definitions are added or removed.

Reviewer map: commits 1 and 2 are small script diffs. Commit 3 only deletes set_option lines and can be skimmed. Of the 659 lines tried across 178 files, 630 are still needed.

🤖 Generated with Claude Code

zhikaip and others added 3 commits October 1, 2026 00:00
…thlib (#41997)

Skip `set_option` lines preceded by a `--` or `/- ... -/` comment, and add
`backward.isDefEq.respectTransparency.types` to the default options.

Co-authored-by: Claude Opus 5.5 <no-reply+claude-opus-5-5@anthropic.com>
`os.killpg` does not exist on Windows, so the first per-module timeout crashed
`rm_set_option.py` and left the build running. Add a `_kill_tree` helper that
falls back to `taskkill /F /T`.

Co-authored-by: Claude Opus 5.5 <no-reply+claude-opus-5-5@anthropic.com>
…ency false

Found by `scripts/rm_set_option.py`: 29 lines in 8 files are no longer needed.

Co-authored-by: Claude Opus 5.5 <no-reply+claude-opus-5-5@anthropic.com>
@github-actions github-actions Bot added the small label Oct 1, 2026
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Thank you for this pull-request (PR). If this is your first PR, welcome to the community!

Below is what will happen next. Please read carefully if you are not familiar with the process. You may open other PRs while this one is being reviewed, and can stack PRs on top of each other, so don't let these steps slow you down.

  1. Some automated checks will be run on your PR. You can see the results of these checks at the buttom of your PR page. If any of these checks fail, you will need to fix the issues before your PR can be merged. You can learn more about these here, including how to run them locally, which is sometimes quicker than relying on the GitHub Actions. If you have never had a PR merged before, you may have to wait for a reviewer to manually start these checks (this is for security).

  2. A reviewer will look at your PR and may ask you to make changes. This may happen a couple of days after you submit your PR, so you may need to be patient. But it should not be longer than that - if it is please bring it to the attention of the community on the Zulip. The level of review will depend on where your PR is submitted. If it is submitted to ./Physlib or ./QuantumInfo, the review will be more thorough than if it is submitted to ./PhyslibAlpha. You can find out more about what the review process is looking for in our review guidelines. If a reviewer adds an awaiting-author label to your PR, address the review comments, then please remove that label by adding a comment with -awaiting-author. This helps us keep track of reviews.

  3. The reviewer will either approve your PR, or request more changes (in which case we return to step 2). Once your PR is approved, it will be merged by a maintainer, this should happen shortly after approval, though you may get more comments at this stage.

Tip: The easiest way to get have a fast review is to submit a PR that is small and self-contained, and has clear documentation explaining why things are the way they are in your chages.

If you have any problems or questions, please reach out to the community on the Zulip.

@jstoobysmith jstoobysmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Approved

@jstoobysmith jstoobysmith added the ready-to-merge This PR is approved and will be merged shortly label Oct 1, 2026
@zhikaip
zhikaip merged commit 7a5a9de into master Oct 1, 2026
9 checks passed
@zhikaip
zhikaip deleted the update_rm_set_option branch October 1, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR is approved and will be merged shortly small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants