feat(PhyslibAlpha/EM): Kirchhoff Current Law - #1706
Conversation
|
Thank you for this pull-request (PR). If this is your first PR, welcome to the community! Below is what will happen next. Please read carefully if you are not familiar with the process. You may open other PRs while this one is being reviewed, and can stack PRs on top of each other, so don't let these steps slow you down.
Tip: The easiest way to get have a fast review is to submit a PR that is small and self-contained, and has clear documentation explaining why things are the way they are in your chages. If you have any problems or questions, please reach out to the community on the Zulip. |
|
I have reservations about calling these results Kirchhoff's current law. To me KCL is a statement about branch currents at the nodes of a lumped-element circuit, while the box result is just integral charge conservation. The wire-junction result is closer, but covers a single node with steady currents, so it is a special case rather than KCL itself. For PhyslibAlpha I'm fine with the implementation as a toy example, but I'd recommend renaming so the names don't suggest more than is proved, e.g. boxOutwardCurrent_eq_zero_of_steady and IsWireJunction.sum_currents_eq_zero, with the file names and module docstrings adjusted to match. The docstrings could mention KCL as motivation. |
|
@zhikaip will make this change before merging |
|
@zhikaip Made the change |
|
Lgtm |
c230f81
Kirchhoff's current law for the functional and distributional cases. Made with Claude Code Opus 5.5.