Skip to content

feat(PhyslibAlpha): current eigenstates of the open tight binding chain - #1708

Merged
jstoobysmith merged 1 commit into
leanprover-community:masterfrom
naype888-cloud:feat-physlibalpha-tight-binding-current-eigenstates
Oct 1, 2026
Merged

jstoobysmith merged 1 commit into
leanprover-community:masterfrom
naype888-cloud:feat-physlibalpha-tight-binding-current-eigenstates

Conversation

@naype888-cloud

@naype888-cloud naype888-cloud commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

hello guys, Joseph Timeroot, im trying to make it faster as i can. what this PR exactly does do?
this PR comes directly from the #1696, where we defines J current from the open chain, and here we got the auto states on himself, it's only one new PR with 180 lines, easy to review i don't want a be a charge for the proyect, so im keepeing short PR with personal Review, awaiting, any way you has the final word here, so im very very glad. tks alot. so, let me be short 4 dots.
1.-currentEingeinstate k: the stationary wave from the open chain , sin((n+1) k * pi/(N+1)), wich it's exactly 0 zero just outside from both ends product fase i^n on each site, then the state remains "psy_k = sumatory_n * i^n * sin ((n+1)k * pi/(N+1)) |n).
2.-current_currentEingeinstate: with phase (psy_k) it's itself current autovalue: J (psy_k) = 2 a * t * cos (k * pi /(N+1)) * psy_k, every single one psy_k has an exact current and his parameter comes directly from "currentEingueinvalue k"
3.-norm_sq_currentEingeinstate. for 1 ≤ k ≤ N the norm it's ||psy_k||² = (N+1)/2, this leaves the road ready to normalize the next one PR's

why and what this PR does itself, this is the floor max current where ( k=1, (current 2 * a * t ) * cos ( pi/ (N+1))), the PR 10 (maxcurrentState) and in subsecuent PR's the 18 PR give us the speed limit |( J )| ≤ 2 | a * t | cos ( pi / (N+1))

reference thigthBindings.

iI hope this commit doesn't take too much of your time. Thanks for everything, guys! Im here waithing for your review and will be ready for any modifications. Thanks once again, timeroot and joseph¡

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the medium label Oct 1, 2026
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Thank you for this pull-request (PR). If this is your first PR, welcome to the community!

Below is what will happen next. Please read carefully if you are not familiar with the process. You may open other PRs while this one is being reviewed, and can stack PRs on top of each other, so don't let these steps slow you down.

  1. Some automated checks will be run on your PR. You can see the results of these checks at the buttom of your PR page. If any of these checks fail, you will need to fix the issues before your PR can be merged. You can learn more about these here, including how to run them locally, which is sometimes quicker than relying on the GitHub Actions. If you have never had a PR merged before, you may have to wait for a reviewer to manually start these checks (this is for security).

  2. A reviewer will look at your PR and may ask you to make changes. This may happen a couple of days after you submit your PR, so you may need to be patient. But it should not be longer than that - if it is please bring it to the attention of the community on the Zulip. The level of review will depend on where your PR is submitted. If it is submitted to ./Physlib or ./QuantumInfo, the review will be more thorough than if it is submitted to ./PhyslibAlpha. You can find out more about what the review process is looking for in our review guidelines. If a reviewer adds an awaiting-author label to your PR, address the review comments, then please remove that label by adding a comment with -awaiting-author. This helps us keep track of reviews.

  3. The reviewer will either approve your PR, or request more changes (in which case we return to step 2). Once your PR is approved, it will be merged by a maintainer, this should happen shortly after approval, though you may get more comments at this stage.

Tip: The easiest way to get have a fast review is to submit a PR that is small and self-contained, and has clear documentation explaining why things are the way they are in your chages.

If you have any problems or questions, please reach out to the community on the Zulip.

@jstoobysmith jstoobysmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Looks good to me.

@jstoobysmith jstoobysmith added ready-to-merge This PR is approved and will be merged shortly PhyslibAlpha Pull requests which are for modifications to PhyslibAlpha. labels Oct 1, 2026
@jstoobysmith
jstoobysmith merged commit db5b5d5 into leanprover-community:master Oct 1, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

medium PhyslibAlpha Pull requests which are for modifications to PhyslibAlpha. ready-to-merge This PR is approved and will be merged shortly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants