refactor(PhyslibAlpha): state the open chain uncertainty on its own Hilbert space - #1709
Conversation
…ilbert space Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thank you for this pull-request (PR). If this is your first PR, welcome to the community! Below is what will happen next. Please read carefully if you are not familiar with the process. You may open other PRs while this one is being reviewed, and can stack PRs on top of each other, so don't let these steps slow you down.
Tip: The easiest way to get have a fast review is to submit a PR that is small and self-contained, and has clear documentation explaining why things are the way they are in your chages. If you have any problems or questions, please reach out to the community on the Zulip. |
1587810
hello guys im been cear as i can on this one, what this PR exactly does?
It's a short one refactor from TightBindingChain/Uncertainty.lean any tnhing changes from #1690 only 13+ lines, why? becouse all ready have the #1695 (SelfAdjointDecompose on finiteHilberSpace) the uncertanty relation energy-position can be instanced on chain HilbertSpace T.HilberSpace, i don't need any more transform the operators to EuclideanSpace C ( Fin N) .
This change ensures that all new elements (current J, eigenstates, and maximum current state) reside inside T.HilbertSpace. By keeping the uncertainty in the same space, PRs #10 and #16 can utilize it directly, eliminating dependence under cross-space conversions.
tks again, im here ready to make any changes after review.