Skip to content

refactor(PhyslibAlpha): state the open chain uncertainty on its own Hilbert space - #1709

Merged
jstoobysmith merged 1 commit into
leanprover-community:masterfrom
naype888-cloud:feat-physlibalpha-tight-binding-uncertainty-own-space
Oct 2, 2026
Merged

jstoobysmith merged 1 commit into
leanprover-community:masterfrom
naype888-cloud:feat-physlibalpha-tight-binding-uncertainty-own-space

Conversation

@naype888-cloud

@naype888-cloud naype888-cloud commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

hello guys im been cear as i can on this one, what this PR exactly does?
It's a short one refactor from TightBindingChain/Uncertainty.lean any tnhing changes from #1690 only 13+ lines, why? becouse all ready have the #1695 (SelfAdjointDecompose on finiteHilberSpace) the uncertanty relation energy-position can be instanced on chain HilbertSpace T.HilberSpace, i don't need any more transform the operators to EuclideanSpace C ( Fin N) .

This change ensures that all new elements (current J, eigenstates, and maximum current state) reside inside T.HilbertSpace. By keeping the uncertainty in the same space, PRs #10 and #16 can utilize it directly, eliminating dependence under cross-space conversions.

tks again, im here ready to make any changes after review.

…ilbert space

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the small label Oct 1, 2026
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Thank you for this pull-request (PR). If this is your first PR, welcome to the community!

Below is what will happen next. Please read carefully if you are not familiar with the process. You may open other PRs while this one is being reviewed, and can stack PRs on top of each other, so don't let these steps slow you down.

  1. Some automated checks will be run on your PR. You can see the results of these checks at the buttom of your PR page. If any of these checks fail, you will need to fix the issues before your PR can be merged. You can learn more about these here, including how to run them locally, which is sometimes quicker than relying on the GitHub Actions. If you have never had a PR merged before, you may have to wait for a reviewer to manually start these checks (this is for security).

  2. A reviewer will look at your PR and may ask you to make changes. This may happen a couple of days after you submit your PR, so you may need to be patient. But it should not be longer than that - if it is please bring it to the attention of the community on the Zulip. The level of review will depend on where your PR is submitted. If it is submitted to ./Physlib or ./QuantumInfo, the review will be more thorough than if it is submitted to ./PhyslibAlpha. You can find out more about what the review process is looking for in our review guidelines. If a reviewer adds an awaiting-author label to your PR, address the review comments, then please remove that label by adding a comment with -awaiting-author. This helps us keep track of reviews.

  3. The reviewer will either approve your PR, or request more changes (in which case we return to step 2). Once your PR is approved, it will be merged by a maintainer, this should happen shortly after approval, though you may get more comments at this stage.

Tip: The easiest way to get have a fast review is to submit a PR that is small and self-contained, and has clear documentation explaining why things are the way they are in your chages.

If you have any problems or questions, please reach out to the community on the Zulip.

@morrison-daniel morrison-daniel added the PhyslibAlpha Pull requests which are for modifications to PhyslibAlpha. label Oct 1, 2026

@jstoobysmith jstoobysmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - approved

@jstoobysmith
jstoobysmith added this pull request to the merge queue Oct 2, 2026
@jstoobysmith jstoobysmith added the ready-to-merge This PR is approved and will be merged shortly label Oct 2, 2026
Merged via the queue into leanprover-community:master with commit 1587810 Oct 2, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PhyslibAlpha Pull requests which are for modifications to PhyslibAlpha. ready-to-merge This PR is approved and will be merged shortly small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants