Fix locking in CompleteOrder error path - #553
Merged
Merged
Conversation
I've been trying to diagnose some flaky CI in `mod_md` over in `apache/httpd` which uses pebble. Along the way Claude identified this problem, which I'm not sure is definitely the root cause but the bug looks genuine.
mcpherrinm
requested review from
a team and
aarongable
and removed request for
a team
September 18, 2026 15:36
aarongable
approved these changes
Sep 21, 2026
aarongable
left a comment
aarongable
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I wish Go had "defer until this loop iteration is exited", to avoid situations like this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been trying to diagnose some flaky CI in
mod_mdover inapache/httpdwhich uses pebble. Along the way Claude identified this problem, which I'm not sure is definitely the root cause but the bug looks genuine.