Regression coverage for conditional action dependency manifests (3.14.5)

[leynos]

Summary

Adds regression coverage for roadmap item 3.14.5 — conditional action
dependency manifests. The change is test-and-documentation only; production
behaviour is unchanged.

The suite now proves:

1. Action-level when and foreach work together.
2. Real command_available(...) resolution selects exactly one nextest or
   legacy action in deterministic present and absent tool worlds.
3. Absent-command fallback performs no impure stdlib operation during
   selection, with a shell-in-when control proving the observable is live.
4. A conditionally selected action's deps lower to IR implicit_deps and
   Ninja | inputs, including {{ item }} substitution and || order-only
   dependencies.

Coverage spans confined in-crate googletest/rstest cases, IR integration tests,
an Insta snapshot validated with real Ninja, and one combined BDD scenario.
The users' guide, developers' guide, design document, roadmap, and living
ExecPlan have been updated.

Validation

• make fmt
• make markdownlint
• make nixie
• make check-fmt
• make typecheck
• make lint
• INSTA_UPDATE=no make test
• coderabbit review --agent after every major milestone and for the final
  branch diff: zero actionable findings

Each new regression layer also passed a targeted sabotage check that produced
the expected assertion-level failure before the production line was restored.

References

• ExecPlan: docs/execplans/3-14-5-regression-coverage-for-conditional-action-dependency-manifests.md
• Roadmap: docs/roadmap.md §3.14.5
• Lody session: https://lody.ai/leynos/sessions/af477183-e313-4319-be64-45d730a10f60

Summary by Sourcery

Add comprehensive regression coverage and documentation for conditional action dependency manifests without changing production behaviour.

Enhancements:

• Add deterministic regression coverage for conditional action selection, including action-level when/foreach, real command-availability resolution, and selection-time purity.
• Verify that dependencies on conditionally selected actions and targets retain their distinct IR and Ninja dependency classes, including item substitution and order-only dependencies.

Build:

• Update the lockfile for the added development testing dependencies.

Documentation:

• Document conditional action dependencies and deterministic testing conventions, clarify the manifest/stdlib boundary, and mark roadmap item 3.14.5 complete.

Tests:

• Add in-crate resolver and impurity-boundary tests, IR assertions, a Ninja snapshot with real-Ninja validation, and a combined BDD scenario.

Chores:

• Apply repository-wide formatting and related test expectation updates required by the current template/rendering behaviour.

[sourcery-ai]

Sorry @leynos, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 3-14-5-regression-coverage-for-conditional-action-dependency-manifests

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[leynos]

@coderabbitai Please investigate the cause of the following issue using codegraph exploration and research, identify a fix and provide an AI coding agent prompt for the fix:

        FAIL [   0.227s] (2042/2269) netsuke-build::stdlib_which_pathext_tests normalized_pathext_governs_resolution
  stdout ───

    running 1 test
    test normalized_pathext_governs_resolution ... FAILED

    failures:

    failures:
        normalized_pathext_governs_resolution

    test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 3 filtered out; finished in 0.11s
    
  stderr ───
    Error: expected command_available('scripted') to be false, got False

    Stack backtrace:
       0: std::backtrace_rs::backtrace::win64::trace
                 at /rustc/c54751567b19c4ceb08b0412d83529c2568cba8b/library\std\src\..\..\backtrace\src\backtrace\win64.rs:85
       1: std::backtrace_rs::backtrace::trace_unsynchronized
                 at /rustc/c54751567b19c4ceb08b0412d83529c2568cba8b/library\std\src\..\..\backtrace\src\backtrace\mod.rs:66
       2: std::backtrace::Backtrace::create
                 at /rustc/c54751567b19c4ceb08b0412d83529c2568cba8b/library\std\src\backtrace.rs:331
       3: std::backtrace::Backtrace::capture
                 at /rustc/c54751567b19c4ceb08b0412d83529c2568cba8b/library\std\src\backtrace.rs:296
       4: <anyhow::Error>::msg::<alloc::string::String>
       5: stdlib_which_pathext_tests::main
       6: std::rt::lang_start::<()>
       7: stdlib_which_pathext_tests::main
       8: stdlib_which_pathext_tests::main
       9: std::rt::lang_start::<()>
      10: stdlib_which_pathext_tests::main
      11: core::ops::function::FnOnce::call_once
                 at /rustc/c54751567b19c4ceb08b0412d83529c2568cba8b/library\core\src\ops\function.rs:250
      12: test::__rust_begin_short_backtrace<enum2$<core::result::Result<tuple$<>,alloc::string::String> >,enum2$<core::result::Result<tuple$<>,alloc::string::String> > (*)()>
                 at /rustc/c54751567b19c4ceb08b0412d83529c2568cba8b/library\test\src\lib.rs:733
      13: test::run_test_in_process
                 at /rustc/c54751567b19c4ceb08b0412d83529c2568cba8b/library\test\src\lib.rs:756
      14: test::run_test::closure$0
                 at /rustc/c54751567b19c4ceb08b0412d83529c2568cba8b/library\test\src\lib.rs:677
      15: test::run_test::closure$1
                 at /rustc/c54751567b19c4ceb08b0412d83529c2568cba8b/library\test\src\lib.rs:707
      16: std::sys::backtrace::__rust_begin_short_backtrace<test::run_test::closure_env$1,tuple$<> >
                 at /rustc/c54751567b19c4ceb08b0412d83529c2568cba8b/library\std\src\sys\backtrace.rs:166
      17: std::thread::lifecycle::spawn_unchecked::closure$1::closure$0
                 at /rustc/c54751567b19c4ceb08b0412d83529c2568cba8b/library\std\src\thread\lifecycle.rs:70
      18: core::panic::unwind_safe::impl$25::call_once
                 at /rustc/c54751567b19c4ceb08b0412d83529c2568cba8b/library\core\src\panic\unwind_safe.rs:275
      19: std::panicking::catch_unwind::do_call
                 at /rustc/c54751567b19c4ceb08b0412d83529c2568cba8b/library\std\src\panicking.rs:574
      20: std::panicking::catch_unwind
                 at /rustc/c54751567b19c4ceb08b0412d83529c2568cba8b/library\std\src\panicking.rs:542
      21: std::panic::catch_unwind
                 at /rustc/c54751567b19c4ceb08b0412d83529c2568cba8b/library\std\src\panic.rs:359
      22: std::thread::lifecycle::spawn_unchecked::closure$1
                 at /rustc/c54751567b19c4ceb08b0412d83529c2568cba8b/library\std\src\thread\lifecycle.rs:68
      23: core::ops::function::FnOnce::call_once<std::thread::lifecycle::spawn_unchecked::closure_env$1<test::run_test::closure_env$1,tuple$<> >,tuple$<> >
                 at /rustc/c54751567b19c4ceb08b0412d83529c2568cba8b/library\core\src\ops\function.rs:250
      24: std::sys::thread::windows::impl$0::new::thread_start
                 at /rustc/c54751567b19c4ceb08b0412d83529c2568cba8b/library\std\src\sys\thread\windows.rs:58
      25: BaseThreadInitThunk
      26: RtlUserThreadStart

  Cancelling due to test failure: 3 tests still running
        PASS [   0.370s] (2043/2269) netsuke-build::stdlib_which_tests command_available_all_kwarg_does_not_affect_bool::case_2_present_all
        SLOW [> 60.000s] (─────────) netsuke-build::packaging_smoke_tests packaged_manifest_retains_build_script_sources
        SLOW [>120.000s] (─────────) netsuke-build::locale_stub_ui_tests harness_compiles_under_a_split_build_dir
        SLOW [>120.000s] (─────────) netsuke-build::packaging_smoke_tests packaged_manifest_retains_build_script_sources
        SLOW [>180.000s] (─────────) netsuke-build::locale_stub_ui_tests harness_compiles_under_a_split_build_dir
        PASS [ 190.926s] (2044/2269) netsuke-build::locale_stub_ui_tests harness_compiles_under_a_split_build_dir
  stdout ───

    running 1 test
    test harness_compiles_under_a_split_build_dir has been running for over 60 seconds
    2026-08-29T12:22:29.839579Z  INFO locale_stub_ui_tests: cargo build test_support completed elapsed_seconds=187.9576708
    2026-08-29T12:22:30.215711Z  INFO locale_stub_ui_tests: rustc metadata harness completed elapsed_seconds=0.2944937
    test harness_compiles_under_a_split_build_dir ... ok

    test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 28 filtered out; finished in 190.90s
    

        PASS [ 152.634s] (2045/2269) netsuke-build::packaging_smoke_tests packaged_manifest_retains_build_script_sources
  stdout ───

    running 1 test
    test packaged_manifest_retains_build_script_sources has been running for over 60 seconds
    2026-08-29T12:22:41.574154Z  INFO packaging_smoke_tests: cargo publish --dry-run completed elapsed_seconds=151.5537833
    2026-08-29T12:22:41.773811Z  INFO packaging_smoke_tests: cargo package --list completed elapsed_seconds=0.1995446
    test packaged_manifest_retains_build_script_sources ... ok

    test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 2 filtered out; finished in 152.61s
    

────────────
     Summary [ 290.103s] 2045/2269 tests run: 2044 passed (3 slow), 1 failed, 2 skipped
        FAIL [   0.227s] (2042/2269) netsuke-build::stdlib_which_pathext_tests normalized_pathext_governs_resolution
warning: 224/2269 tests were not run due to test failure (run with --no-fail-fast to run all tests, or run with --max-fail)
error: test run failed
make: *** [Makefile:101: test-nextest] Error 100

https://github.com/leynos/netsuke/actions/runs/33251236690/job/99097151318?pr=387

[codescene-access]

No quality gates enabled for this code.