Conversation
Checkpoint only: lowering, A/B/C fixture, three generated variants, thirteen mutations and located rejection controls prepared. Static checks only; Lean and EVM validations remain pending until the serial ifelse campaign finishes.
Keep named constants within unsigned integer and bool declarations. Add bool and narrow unsigned positive controls plus address and bytes32 near misses. Static review checkpoint; execution remains pending the active serial campaign.
solc 0.8.34 rejects 2E+3; use 2E3 for the intended value 2000. All three source variants compile to identical deployed runtime with metadata disabled. Importer, mutation and A/B/C gates remain pending; no assertions or golden models changed.
Solc AST preserves .5 and underscores. Normalize separators and interpret an omitted whole part as zero, retaining exact rational scaling and rejection. Add fixture values, normalized variants, two mutation rules and three located controls. Solc-only preflight passes three identical runtimes and all thirteen numeric control sources; Lean and A/B/C validation pending.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solidity numeric literals such as
1 days,.5 hoursand1e-3 etherpreviously rejected. Lower exact integral decimal/scientific/hex values and time/currency units using natural rational arithmetic, resolve unsigned/bool constants by declaration ID, and admit bounded natural constant sums. Fractional results, oversized words and unsupported rational operations fail with located diagnostics.Add a stateful A/B/C fixture with three equivalent spellings, near-miss rejection controls, 16 semantic mutants with minimal witnesses, generated variants and support/trust documentation. No golden model or pilot provenance changes. This PR is stacked on
feat/solidity-import-if-else-linux(#2466).Validation on exact head
b0fa7b0e2d97afede09dd603884c4fea42debc7a: all 12 serial gates passed (make check, full Verity/Contracts/SolidityImportSmoke build, whole mutation suite, smoke, loss, generated programs, axiom generator, pinned Midnight pilot, stateful composite with 64 transactions per variant, require, custom require, proof axiom audit). Terminal receipts:linux-validation/numeric-b0fa7b0e-1/complete.jsonin the mission workspace. The development documentation records the earlier focused campaign; release validation is now complete. Full Midnight coverage is being remeasured separately; this PR does not claim complete Midnight support.