Conversation
#246) * docs(plan): record 0.2.38 delivery * docs(plan): roadmap #243 dispatch card (wp7) * docs(plan): fold #243 architect reflection * docs(plan): fold #243 audit round 1 * feat(subagents): SessionStart dispatch card, model aliases and spawn-ready role args (#243) * fix(subagents): serialize MCP replies, ship dispatch-card dist, detect V2 by companion tools * docs(plan): record wp7 delivery * docs(plan): plan 0.2.39 release (wp8) * docs(plan): fold wp8 audit * chore(release): prepare codexclaw 0.2.39
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 22ea08c5a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const v1 = has(/(send_input|close_agent|resume_agent)$/), v2 = has(/(followup_task|interrupt_agent|list_agents)$/); | ||
| if (v1 === v2) throw new Error("collab family unresolved: v1=" + v1 + " v2=" + v2); | ||
| const a = {message:"Report your model and say OK; do not edit files.",model:"command-code/deepseek-deepseek-v4.1-flash",reasoning_effort:"low"}; | ||
| text(await tools[s[0]](v1 ? a : {...a, task_name:"model_probe", fork_turns:"none"}));`; |
There was a problem hiding this comment.
Omit unsupported model fields from V2 spawn
When CODEXCLAW_SPAWN_V1 is unset on the V2 collaboration surface, this branch spreads a, so the generated call includes model and reasoning_effort; the V2 spawn_agent contract accepts task_name, message, and fork_turns but not those model fields. Tool argument validation therefore rejects the advertised first-cell call instead of spawning an agent. Construct the V2 arguments from only fields supported by its live schema rather than sharing the V1 argument object.
Useful? React with 👍 / 👎.
Promotes dev at 22ea08c to main for the codexclaw 0.2.39 release. It carries #246, which implements #243: the SessionStart subagent dispatch card with dated model aliases,
spawnArgsandstaleModelinsubagents_get, and serialized MCP stdio replies.Dev evidence at 22ea08c: push CI and Packed install lifecycle succeeded. WSL is confirmed before merge.