fix(dashboard): guide browser pairing with the hub and preserve error meaning - #4378
fix(dashboard): guide browser pairing with the hub and preserve error meaning#4378lidge-jun wants to merge 6 commits into
Conversation
Share browser session readiness with the shell, explicitly refresh retained resources after pairing, distinguish authentication/permission/network/shape failures, and preserve labelled stale data only for non-auth failures. Show hub identity and current-origin pairing command with copy and cancellation feedback. Local suites NOT RUN; hosted build and rendered review follow.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
리뷰 · 우선순위 54 / 80이 PR은 연결된(connected) 대시보드가 허브 브라우저 인증을 기다리는 동안, 사용자에게 “지금 뭘 해야 하는지”를 정확히 알려 주는 작업입니다. 현재 핵심 동작은 네 갈래입니다. 첫째, 페어링 폼에 허브 현재
메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved. |
Summary
A connected dashboard awaiting browser authentication now shows the hub identity and a copyable
ocx gui pair --origincommand for its exact browser origin. It explains where to obtain the one-time code and distinguishes it from data/API administrator credentials.The shell and Dashboard share session readiness. Pairing success explicitly refreshes retained resource stores; expiry restores pairing; 403 permission denial keeps separate guidance. Authentication failures hide protected data, while other refresh failures can show labelled stale data with Retry. Connected clients are not told to run
ocx start. Obsolete pairing submissions are cancelled before session installation.Addresses #4206 and #4208 together. Independent PR targeting dev, with no native stack or live-service change.
Verification
git diff --cached --check: passed. Independent design and entry audits passed after cache-refresh and state-contract corrections; implementation source review passed; final hosted execution remains pending.Checklist