feat(meta-muse): expose max reasoning effort to routed clients - #5094
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (11)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughChangesMeta Muse Code support
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant meta_muse_registry
participant createResponsesPassthroughAdapter
participant Responses_wire_request
meta_muse_registry->>createResponsesPassthroughAdapter: provide max reasoning and static headers
createResponsesPassthroughAdapter->>Responses_wire_request: send reasoning.effort=max
Responses_wire_request-->>createResponsesPassthroughAdapter: use explicit User-Agent override when provided
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. Automatic draft conversion failed. Please convert this pull request to a draft manually until every box above is ticked. |
리뷰 · 우선순위 64 / 80이 PR은 Meta Muse 로그인으로 쓰는 모델 두 개에 추론 단계 이제는 베이스는
메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
리뷰 · 우선순위 71 / 80이 PR은 고친 방식은 사다리를 둘로 나눈 것입니다. 요청 헤더도 바뀝니다. 테스트는 세 곳입니다. 두 모델 사다리에 베이스는 라인 - 이게 무슨 문제다 src/providers/registry/entries-core.ts · staticHeaders User-Agent - 나가는 값은 src/providers/registry/entries-core.ts · src/providers/registry/entries-core.ts · 붙여 넣은 키 - 이 User-Agent는 브라우저 디바이스 로그인에만 붙지 않습니다. tests/providers/meta-muse-oauth.test.ts · max reaches the Responses wire - 본문이 메인테이너의 판단이 필요한 지점
너의 추천 사다리를 나누는 쪽은 맞습니다. 머지 전에 User-Agent만 고르면 됩니다. 제품 이름 이 댓글은 grok-bot이 작성했습니다 |
9797716 to
dbb047b
Compare
Summary
maxfor bothmeta-museMuse Spark 1.3 models. Previously the shared Meta effort ladder stopped atxhigh, so routed clients such as Grok omittedmaxand requests could be clamped before reaching Meta.meta-museits own identity effort map andmuse-build/1.3.0 (opencodex compatibility)User-Agent through the existing registry header seam. Explicit operator headers retain precedence;meta-modeland OpenCode Go keep their existing ladders.Reviewer entry points:
model-seeds.tsandentries-core.tsdefine the contract;meta-muse-oauth.test.tsverifies the wire effort and header together against a Grok caller header; the Grok injection test verifies picker propagation. The small structure-document updates synchronize the required source ownership map.Verification
meta-muse-oauth,muse-key-quota, andgrok-effort-inject.meta-model-api-providerandopencode-go-muse-context.bun run typecheck,bun run structure:check,bun run privacy:scan, andgit diff --check.cd docs-site && bun install --frozen-lockfile && bun run build(465 pages).979771698: the full test set in four CI-style shards, 27,081 pass / 56 skip / 0 fail across 1,383 files. The equivalent unsharded Bun process wedged in a worker without emitting a test failure; CI-style sharding completed every file in fresh processes.Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Summary by CodeRabbit
New Features
maxreasoning effort option to both Meta Muse models.maxoption in the Grok effort picker for Meta Muse models.Documentation