Skip to content

fix(catalog): exclude deepseek-v4-pro on deepseek and opencode-go - #5282

Closed
luvs01 wants to merge 1 commit into
lidge-jun:devfrom
luvs01:fix/deepseek-v4-pro-exclusions
Closed

luvs01 wants to merge 1 commit into
lidge-jun:devfrom
luvs01:fix/deepseek-v4-pro-exclusions

Conversation

@luvs01

@luvs01 luvs01 commented Sep 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Add the two missing deepseek-v4-pro routed-catalog exclusions in src/codex/catalog/parsing.ts: deepseek/deepseek-v4-pro and opencode-go/deepseek-v4-pro. DeepSeek retired the model on 2026-09-14 and both providers discover models live, so the exclusion is what keeps the retired, uncallable row out of dashboard and Codex pickers. structure/catalog.md now notes that retired aliases retained in generated metadata are covered.

Verification

  • bun test tests/codex-integration/codex-catalog.test.ts — 339 pass, 0 fail
  • bun x tsc --noEmit — clean

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Review readiness checklist

This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:

  • All CI tests are green on my local testing.

  • I pushed my PR to the latest dev commit.

  • I resolved all correct Codex and CodeRabbit findings.

  • My PR is ready for review.

Summary by CodeRabbit

  • Bug Fixes

    • Removed the retired DeepSeek V4 Pro model from routed catalogs for the DeepSeek and OpenCode Go providers, preventing it from appearing with unavailable capabilities.
  • Documentation

    • Clarified that retired model aliases may be excluded from dashboard and Codex model pickers.
  • Tests

    • Added coverage to verify the retired model is excluded for both providers.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Sep 20, 2026
@github-actions

github-actions Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

✅ READY

  • all PR quality gates passed; the review readiness checklist is complete.

Review readiness checklist

  • ✅ All CI tests are green on my local testing.
  • ✅ I pushed my PR to the latest dev commit.
  • ✅ I resolved all correct Codex and CodeRabbit findings.
  • ✅ My PR is ready for review.

✅ 4/4 boxes ticked.

Automatic ready-for-review conversion failed; please mark the pull request ready manually if it is still a draft.
The review-ready label marks this PR as ready; review automation runs independently.
Maintainers notified: @lidge-jun @Ingwannu

@github-actions
github-actions Bot marked this pull request as draft September 20, 2026 07:23
@coderabbitai

coderabbitai Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: f31836a1-b8c1-4494-b971-a51359d3d556

📥 Commits

Reviewing files that changed from the base of the PR and between 447ac22 and 48c2556.

📒 Files selected for processing (3)
  • src/codex/catalog/parsing.ts
  • structure/catalog.md
  • tests/codex-integration/codex-catalog.test.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The routed catalog now excludes retired deepseek-v4-pro entries for the deepseek and opencode-go providers. Integration tests verify the exclusions, and catalog documentation describes the behavior.

Changes

Routed catalog exclusion

Layer / File(s) Summary
Compatibility exclusion and validation
src/codex/catalog/parsing.ts, tests/codex-integration/codex-catalog.test.ts, structure/catalog.md
Lines 197-198 add both provider/model slugs to ROUTED_MODEL_COMPATIBILITY_EXCLUSIONS. Lines 7113-7114 verify that routed catalogs reject both entries. Lines 61-62 document exclusions for uncallable upstream rows and retired aliases retained in generated metadata.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the main change: excluding deepseek-v4-pro for the deepseek and opencode-go providers. It matches the documented code and test changes.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@luvs01
luvs01 marked this pull request as ready for review September 20, 2026 07:27
@github-actions
github-actions Bot marked this pull request as draft September 20, 2026 07:27
@lidge-jun

Copy link
Copy Markdown
Owner

리뷰 · 우선순위 42 / 80

이 PR은 DeepSeek이 2026-09-14에 내려보낸 deepseek-v4-pro가, 모델을 실시간으로 받아오는 deepseek와 opencode-go 쪽 목록에 아직 남는 문제를 막는 작은 수정입니다. 이미 같은 제외 목록에 command-code·orcarouter 같은 다른 제공자 slug는 들어 있었는데, 정작 라이브 디스커버리로 목록을 채우는 두 제공자가 빠져 있었습니다. 그래서 대시보드·Codex 모델 고르기 화면에 호출할 수 없는(또는 능력이 깨진) 행이 다시 보일 수 있었습니다. 코드에는 두 slug를 ROUTED_MODEL_COMPATIBILITY_EXCLUSIONS에 넣고, 테스트로 둘 다 숨겨지는지 확인하며, structure/catalog.md에는 “은퇴한 별칭이 메타데이터에 남아 있어도 제외한다”는 설명을 한 줄 보강했습니다. 범위는 파일 3개·순증가 6줄 수준으로 좁고, base도 dev라서 방향은 맞습니다.

라인 src/codex/catalog/parsing.ts — 제외 추가 자체는 맞고, 같은 주석 블록이 이미 “라이브 디스커버리라 레지스트리 행 삭제만으로는 안 빠진다”고 설명해 두었는데 그 바로 옆에 두 slug가 없었던 누락 보완입니다. 새 결함은 안 보입니다.
라인 tests/codex-integration/codex-catalog.test.ts — deepseek/opencode-go 두 케이스를 넣은 것은 좋습니다. 다만 상위 describe 이름이 Gemini image-capable exemption이라 주제와 어긋납니다. 이번 PR에서 꼭 고칠 필요는 없고, 나중에 블록을 나눌 때 정리하면 됩니다.
경로 PR 본문 체크리스트 — readiness 4칸이 모두 비어 있고 게이트가 DRAFT입니다. 코드 품질 이슈라기보다 머지 전 절차가 아직입니다.

메인테이너의 판단이 필요한 지점

라이브로 모델을 긁어 오는 제공자에서, 은퇴 모델을 레지스트리에서만 지우고 exclusion을 빼먹는 패턴이 또 생길 수 있습니다. 이번처럼 JAWCODE_CATALOG_AUGMENT_PROVIDERS(deepseek·opencode-go)를 은퇴 작업의 체크 항목으로 고정할지, 아니면 지금처럼 발견될 때마다 좁게 고칠지 정하면 이후 비슷한 PR이 줄어듭니다. 체크리스트·draft 해제는 작성자 쪽이 채우면 됩니다.

너의 추천

내용상 머지해도 되는 작은 버그픽스입니다. 작성자가 readiness 체크리스트를 채우고 draft를 푼 뒤 dev에 넣는 쪽을 추천합니다. 테스트 describe 이름 정리는 이번 PR 범위 밖으로 두고, 필요하면 후속 정리 PR로 가도 됩니다.

이 댓글은 grok-bot이 작성했습니다

@luvs01

luvs01 commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

Consolidated into #5529 in native Stack #5505.

Source head: fd795dbf61dc4577fa2fb7e1295ce38a8ef22a0c. Replacement head: d11f35f56f1da8bcf38e9db788d14892a49c31ee.

Source commits match by stable Git patch ID. Follow-up d11f35f fixes case-folded cap handling and moves the unchanged exclusion regression into a registered sibling file. Focused combined-head tests: 44 passed; prepared catalog tests: 515 passed. Full CI, docs build and independent review remain pending.

Closing this duplicate standalone review entry at the author's request after verifying migration. This is not a merge or release claim; remaining integration checks and reviews are tracked on the draft replacement. Original branches are retained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working review-ready

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants