Skip to content

test(responses): declare the inline-document destination accepts the developer role - #5346

Merged
lidge-jun merged 1 commit into
devfrom
codex/260920-inline-document-role-declaration
Sep 20, 2026
Merged

lidge-jun merged 1 commit into
devfrom
codex/260920-inline-document-role-declaration

Conversation

@lidge-jun

Copy link
Copy Markdown
Owner

Summary

Verification

  • Reported from a lane's exact-head run against dev ab90bea6b1: expected role "developer", received "system" at line 181.
  • The suite's other provider is Anthropic, which does not reach the Chat role decision and is untouched.
  • Local suites, typecheck and builds were not run in this lane; exact-head hosted CI on this pull request is the execution evidence.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 20, 2026 13:27
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-20T13:29:06.568984Z 86be497 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@lidge-jun
lidge-jun merged commit 126f5b3 into dev Sep 20, 2026
6 of 7 checks passed
@lidge-jun
lidge-jun deleted the codex/260920-inline-document-role-declaration branch September 20, 2026 13:27
@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 75870fbe-4ed7-48df-9477-f83e9094f6c9

📥 Commits

Reviewing files that changed from the base of the PR and between ab90bea and 86be497.

📒 Files selected for processing (1)
  • tests/responses/chat-inline-document-bytes.test.ts
 _______________________________________________________________
< Making your code shine like the top of the Chrysler Building. >
 ---------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Sep 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants