test(responses): declare the inline-document destination accepts the developer role - #5346
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
Summary
devis red on shard 3/4:tests/responses/chat-inline-document-bytes.test.tsasserts that a document survives on adeveloperturn and reads the wire role to prove it. fix(openai-chat): fold the developer role unless a destination records that it accepts it #5334 folds that role tosystemunless a destination records acceptance, and this suite records nothing, so the case fails atab90bea6b1.toEqualon a suite whose subject is documents rather than roles.Verification
devab90bea6b1:expected role "developer", received "system"at line 181.Checklist