Skip to content

fix(desktop): ad-hoc sign bun sidecar on macOS after prepare #5559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
agentHits wants to merge 2 commits into from
Closed

fix(desktop): ad-hoc sign bun sidecar on macOS after prepare #5559

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cc98f5
fix(desktop): ad-hoc sign bun sidecar on macOS after prepare
agentHits Sep 22, 2026
ecb5108
fix(desktop): gate sidecar signing on darwin target, not just host
agentHits Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions desktop/scripts/prepare-sidecar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,5 +55,11 @@ mkdirSync(binaries, { recursive: true });
mkdirSync(resources, { recursive: true });
const destination = join(binaries, `ocx-${triple}${target.startsWith("bun-windows-") ? ".exe" : ""}`);
copyFileSync(executable, destination);
if (process.platform === "darwin" && target.startsWith("bun-darwin-")) {
// Bun linker-signed output is killed by macOS page validation (CODESIGNING
// "Invalid Page"); seal ad-hoc so the bundled sidecar actually launches.
const sign = Bun.spawnSync(["codesign", "-s", "-", "-f", destination], { stdout: "inherit", stderr: "inherit" });
if (sign.exitCode !== 0) process.exit(sign.exitCode);
}
cpSync(join(repoRoot, "gui", "dist"), resources, { recursive: true });
console.log(`Prepared ${destination}`);
Loading