-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix(desktop,cli): bundle lane G — sidecar signing, restart warning, probe ceilings, hidden autostart, mise updates, Linux packaged E2E #5682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4551025
fix(desktop): ad-hoc sign the bun sidecar on macOS after prepare
lidge-jun dc92d36
fix(cli): warn about state loss before and after codex-restart
lidge-jun 650914e
feat(server): OCX_PROBE_TIMEOUT_MS raises the liveness probe ceilings
lidge-jun 8ed256e
perf(desktop): keep a hidden login launch on the startup surface
lidge-jun 0ac48b3
fix(update): respect mise-owned installations
lidge-jun f5cb081
test(desktop): add the Linux packaged-shell E2E driver
lidge-jun 471f3f7
ci(desktop): run the Linux packaged-shell E2E and isolate Linux relea…
lidge-jun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
The Linux release builds dropped
--verbose, so linuxdeploy diagnostics are lost.The old single
Build desktop bundlesstep ranbunx tauri --verbose build ...on Linux. The comment at lines 429-430 gives the reason: "linuxdeploy suppresses its own stderr at the default verbosity." The newBuild Linux AppImage bundlestep (line 443) andBuild Linux deb bundlestep (line 452) runbunx tauri buildwithout--verbose. If linuxdeploy or theappimage-patchelf.pywrapper fails during a release, the log will not show the cause.Two things follow from this:
runner.os == 'Linux' && '--verbose'branch at line 431 is now dead, because that step hasif: runner.os != 'Linux'.The same gap exists in
.github/workflows/ci.ymlat line 1442 (Build Linux AppImage).Proposed fix
- name: Build Linux AppImage bundle if: runner.os == 'Linux' working-directory: desktop env: CARGO_TARGET_DIR: ${{ runner.temp }}/opencodex-appimage-target + DESKTOP_TARGET: ${{ matrix.target }} TAURI_SIGNING_PRIVATE_KEY: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY }} TAURI_SIGNING_PRIVATE_KEY_PASSWORD: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY_PASSWORD }} - run: bunx tauri build --ci --target ${{ matrix.target }} --bundles appimage + # linuxdeploy suppresses its own stderr at the default verbosity. + run: bunx tauri --verbose build --ci --target "$DESKTOP_TARGET" --bundles appimageIn the non-Linux step, remove the dead
--verboseexpression and move the linuxdeploy comment to the AppImage step.📝 Committable suggestion
🧰 Tools
🪛 zizmor (1.30.0)
[warning] 443-443: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[warning] 452-452: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
🤖 Prompt for AI Agents