Skip to content

fix(ci): repair dev after the 2.65.0 round merges - #5768

Merged
lidge-jun merged 1 commit into
devfrom
codex/260925-fix-dev-ci-after-round
Sep 24, 2026
Merged

lidge-jun merged 1 commit into
devfrom
codex/260925-fix-dev-ci-after-round

Conversation

@lidge-jun

Copy link
Copy Markdown
Owner

Summary

Fixes the three failures on the dev Cross-platform CI run 36028905040 (tip 9cf3a06889) left by this round's merges:

Verification

  • bun run typecheck: pass. bun run structure:check: pass.
  • bun test tests/providers/deepseek-inbound-wire.test.ts tests/ci-workflows/file-size-ratchet.test.ts tests/usage/key-attribution.test.ts tests/usage/request-log-attempt-identity.test.ts: 63 pass, 0 fail.
  • cd gui && bun test tests/provider-icons.test.ts: 6 pass, 0 fail.
  • Full suite left to the dev Cross-platform CI run dispatched after merge.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed. (No user-facing change.)
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults. (None touched.)

Move the account-rotation split out of request-log.ts for the 2,000-line limit, wire the claude-cli provider icon, and align the DeepSeek terminal-repair test with destination-based policy.
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 24, 2026 16:52
@lidge-jun
lidge-jun merged commit 45d3447 into dev Sep 24, 2026
3 of 7 checks passed
@lidge-jun
lidge-jun deleted the codex/260925-fix-dev-ci-after-round branch September 24, 2026 16:52
@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 27260098-f811-45b5-a194-344abd0b0d80

📥 Commits

Reviewing files that changed from the base of the PR and between 9cf3a06 and 14e228c.

📒 Files selected for processing (4)
  • gui/src/provider-icons.ts
  • src/server/request-log-account-rotation.ts
  • src/server/request-log.ts
  • tests/providers/deepseek-inbound-wire.test.ts
 _____________________________________________________________________________________
< All idioms must be learned. Good idioms only need to be learned once. - Alan Cooper >
 -------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T16:54:14.243854Z 14e228c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant