Release/v0.4.3

.github/workflows/model-weights.yml

@@ -0,0 +1,40 @@
+name: Model weight regressions
+
+on:
+  pull_request:
+    branches: [dev, main]
+    paths:
+      - 'api/**'
+      - 'electron/**'
+      - 'src/areas/models/**'
+      - 'src/shared/types/electron.d.ts'
+      - 'package*.json'
+      - '.github/workflows/model-weights.yml'
+
+permissions:
+  contents: read
+
+jobs:
+  model-weights:
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, windows-latest]
+        python: ['3.11', '3.12']
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version: '22'
+          cache: npm
+      - uses: actions/setup-python@v5
+        with:
+          python-version: ${{ matrix.python }}
+      - run: npm ci --ignore-scripts --no-audit --no-fund
+      - run: python -m pip install fastapi httpx
+      - name: Download, deletion, manifests and install queue
+        run: node --test electron/main/model-weight-ipc.test.mjs electron/main/model-sources.test.mjs electron/main/model-download-plan.test.mjs electron/main/model-download-preload.test.mjs electron/main/extension-install-utils.test.mjs src/areas/models/utils.test.mjs
+      - name: Python runtime and download regressions
+        working-directory: api
+        run: python -m unittest tests.test_model_sources tests.test_model_router tests.test_generator_registry tests.test_extension_process tests.test_runner

README.md

@@ -69,6 +69,9 @@ npm run build
 
 ## Platform notes
 
+- AMD GPUs are supported through ROCm on Linux and Windows: a Radeon card is detected
+  automatically and extensions are steered to ROCm PyTorch wheels, with no ROCm install
+  required. See [docs/running-on-amd-rocm.md](docs/running-on-amd-rocm.md).
 - macOS support targets Apple Silicon only.
 - macOS uses native window controls. Windows and Linux keep the existing custom controls.
 - The top bar includes a live RAM indicator sourced from the main process.
@@ -106,11 +109,188 @@ Modly supports external model and process extensions. Each extension is a GitHub
 
 ![Install models](docs/install-models.png)
 
+### Multiple Hugging Face repositories per model node
+
+A model node whose weights are split across repositories can declare
+`model_sources`. Modly validates every source, downloads them sequentially in
+one Models-page action, and considers the node installed only when every
+declared check exists.
+
+```json
+{
+  "id": "generate",
+  "model_sources": [
+    {
+      "id": "primary",
+      "provider": "huggingface",
+      "repo_id": "org/main-model",
+      "destination": ".",
+      "checks": ["model.safetensors"]
+    },
+    {
+      "id": "encoder",
+      "provider": "huggingface",
+      "repo_id": "org/encoder",
+      "revision": "v1.0",
+      "destination": "auxiliary/encoder",
+      "include_prefixes": ["config.json", "model.safetensors"],
+      "checks": ["config.json", "model.safetensors"]
+    }
+  ]
+}
+```
+
+`destination`, filters, and checks use safe POSIX paths relative to the node's
+model directory. Every check must name a regular, non-empty file included by
+that source's filters; invalid plans fail before any file is downloaded. Pin a
+tag or commit in `revision` when reproducible weights are required. The only
+supported provider is `huggingface`. Existing nodes that use `hf_repo`,
+`download_check`, `hf_include_prefixes`, and `hf_skip_prefixes` keep their
+original behavior.
+
+### Shared weights inside one model extension
+
+Multi-node model extensions can declare extension-scoped `weight_groups` and
+reference them from any sibling node. Shared files are downloaded once under
+`<models-dir>/<extension-id>/_shared/<group-id>`, while node-specific
+`model_sources` stay under the node's existing model directory.
+
+```json
+{
+  "id": "pixal3d",
+  "type": "model",
+  "weight_groups": [
+    {
+      "id": "pixal3d-base",
+      "model_sources": [
+        {
+          "id": "base",
+          "provider": "huggingface",
+          "repo_id": "TencentARC/Pixal3D",
+          "revision": "<pinned-revision>",
+          "destination": ".",
+          "checks": ["pipeline.json"]
+        }
+      ]
+    }
+  ],
+  "nodes": [
+    {
+      "id": "generate",
+      "weight_groups": ["pixal3d-base"]
+    },
+    {
+      "id": "worldsculpt",
+      "weight_groups": ["pixal3d-base"],
+      "model_sources": [
+        {
+          "id": "adapter",
+          "provider": "huggingface",
+          "repo_id": "AlayaLab/WorldSculpt",
+          "revision": "<pinned-revision>",
+          "destination": ".",
+          "checks": ["model.safetensors"]
+        }
+      ]
+    }
+  ]
+}
+```
+
+At runtime, `MODEL_DIR` remains the selected node's private directory.
+Subprocess extensions also receive `MODEL_ID`, `MODEL_NODE_ID`, and a JSON
+`SHARED_MODEL_DIRS` map in their environment. Both direct and subprocess generator
+instances receive `MODEL_ID`, `MODEL_NODE_ID`, and the resolved mapping in
+`shared_model_dirs` before `load()`. Direct generators use these instance attributes,
+not process-global environment variables, to distinguish sibling nodes.
+Shared groups are installed through their dependent nodes; the drawer exposes
+shared-group status and explicit removal. Removing private node data never removes a shared group;
+shared-group removal is a separate action that identifies every affected node.
+
+### Separately installable weight variants
+
+A model node that publishes the same weights in several variants (quantizations,
+precisions…) can declare `weight_variants` next to `hf_repo`. The Extensions page
+lists every variant under the node, and each one is downloaded or deleted on its own.
+
+```json
+{
+  "id": "generate",
+  "hf_repo": "org/model-gguf",
+  "download_check": "pipeline.json",
+  "hf_include_prefixes": ["pipeline.json", "encoder/", "dit/"],
+  "params_schema": [
+    {
+      "id": "quant",
+      "label": "Quantization",
+      "type": "select",
+      "default": "Q5_K_M",
+      "options": [
+        { "value": "Q4_K_M", "label": "Q4_K_M" },
+        { "value": "Q5_K_M", "label": "Q5_K_M" }
+      ]
+    }
+  ],
+  "weight_variants": {
+    "param": "quant",
+    "default": "Q5_K_M",
+    "options": [
+      {
+        "id": "Q4_K_M",
+        "label": "Q4_K_M",
+        "size_gb": 2.4,
+        "vram_gb": 6,
+        "include_prefixes": ["dit/model_Q4_K_M.gguf"],
+        "checks": ["dit/model_Q4_K_M.gguf"]
+      },
+      {
+        "id": "Q5_K_M",
+        "include_prefixes": ["dit/model_Q5_K_M.gguf"],
+        "checks": ["dit/model_Q5_K_M.gguf"]
+      }
+    ]
+  }
+}
+```
+
+- `param` names the `params_schema` select whose values are the variant ids. That
+  param must exist on the node (or on the extension, as its fallback), and when it
+  declares `options` they must cover every variant id.
+- `size_gb` (download size) and `vram_gb` (approximate VRAM the variant needs) are
+  optional positive numbers, shown next to the variant when present.
+- Every install downloads the shared files (`hf_include_prefixes`, with every
+  variant's files excluded automatically) plus one variant: the one asked for, or the
+  `default` one — the first option when `default` is omitted. Files already complete
+  on disk are skipped, so adding a second variant only fetches that variant.
+  Only declared variants are excluded from the shared pass: keep
+  `hf_include_prefixes` narrow enough that a variant the repository publishes but
+  the manifest does not declare (e.g. an extra `dit/model_Q8_0.gguf`) is not
+  downloaded with every install.
+- A variant is installed when all of its `checks` exist; the node is installed once
+  its `download_check` and at least one variant are present.
+- Generation fails with an explicit message when the selected variant is not
+  installed, and the node's selector labels those options `(not installed)`.
+- `include_prefixes` and `checks` are safe POSIX paths relative to the node's model
+  directory. Prefixes of two variants cannot overlap, `download_check` stays outside
+  every variant, and `weight_variants` cannot be combined with `model_sources`.
+
 ---
 
 ## Workflows
 Start with a basic workflow first. For example, on the "Workflows" tab, try: Image -> Generate Mesh -> Add to Scene. Make sure there is a connection between each of the steps. Go to the "Generate" tab, make sure the workflow is selected, then click on "Generate 3D Model". Click on "Settings/Logs/Errors" to see any issues.
 
+Model extensions may also declare `scene` as a node input or output. A scene is
+a workspace directory containing `scene-manifest.json` with schema
+`modly.scene-manifest.v1`; it is not an arbitrary JSON file. Use the **Load
+Scene** workflow node to select and validate an existing scene directory.
+Scene-capable generators implement `generate_artifact(input_kind,
+artifact_path, ...)`; legacy image generators and `POST /generate/from-image`
+remain unchanged. The generic `POST /generate/from-artifact` boundary currently
+accepts only `scene`, leaving future artifact kinds to separate reviewed changes.
+For this first contract, `scene` is model-only and must be declared as the single
+`input` value (not inside `inputs`); process and mixed-input scene nodes are rejected.
+Model nodes may still accept multiple images and produce a scene.
+
 
 ## Modly CLI
 

api/README.md

@@ -29,6 +29,7 @@ uvicorn main:app --host 127.0.0.1 --port 8765 --reload
 | GET | `/model/status` | Model download / load status |
 | GET | `/model/download` | SSE stream of download progress |
 | POST | `/generate/from-image` | Start image-to-3D job |
+| POST | `/generate/from-artifact` | Start a typed-artifact model job (`scene` only) |
 | GET | `/generate/status/{job_id}` | Poll job status |
 
 ## Model

api/main.py

@@ -12,7 +12,7 @@
 from services.stdio_utf8 import ensure_utf8_stdio
 ensure_utf8_stdio()  # must run before any print/logging hits the pipe
 
-from routers import generation, model, optimize, status, settings, extensions, export, workflow_runs, agent
+from routers import generation, model, optimize, status, settings, extensions, export, workflow_runs, agent, llm
 
 
 @asynccontextmanager
@@ -21,8 +21,10 @@ async def lifespan(app: FastAPI):
     from services.generator_registry import generator_registry
     generator_registry.initialize()
     yield
-    # Shutdown: unload all models
+    # Shutdown: unload all models and stop the local LLM server
     generator_registry.unload_all()
+    from services.llm_server import llama_pool
+    llama_pool.unload_all(force=True)
 
 
 class _StatusFilter(logging.Filter):
@@ -34,7 +36,7 @@ def filter(self, record):
 
 app = FastAPI(
     title="Modly API",
-    version="0.4.2",
+    version="0.4.3",
     lifespan=lifespan,
 )
 
@@ -57,6 +59,7 @@ def filter(self, record):
 app.include_router(export.router,          prefix="/export")
 app.include_router(workflow_runs.router,   prefix="/workflow-runs")
 app.include_router(agent.router)
+app.include_router(llm.router,             prefix="/llm")
 
 # Serve generated files from workspace — dynamic so path changes take effect immediately
 @app.get("/workspace/{full_path:path}")