fix(sandbox): landlock 0.4.5 API compatibility#97
Open
Svtter wants to merge 1 commit into
Open
Conversation
landlock 0.4.5 changed AccessFs methods to return BitFlags<AccessFs> instead of AccessFs, and removed RulesetHandle. This patch updates imports and return types to match. Closes lingcoder#96
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
crab-sandboxfails to compile withlandlock = "0.4"(resolves to 0.4.5). The landlock crate made a breaking change within the 0.4.x semver range.Closes #96
Changes
All changes in
crates/sandbox/src/backend/landlock.rs:Access,BitFlags,RulesetCreatedAttr; removed unusedRulesetHandlepath_access_to_landlocknow returnsBitFlags<AccessFs>instead ofAccessFs.into()calls:from_read/from_write/from_allalready returnBitFlags<AccessFs>Verification
cargo build --release -p crab-cli # Compiles successfully, produces 34M binaryError messages before fix