sync: from linuxdeepin/dde-session-shell - #544
Open
deepin-ci-robot wants to merge 1 commit into
Open
deepin-ci-robot wants to merge 1 commit into
deepin-ci-robot wants to merge 1 commit into
Conversation
Synchronize source files from linuxdeepin/dde-session-shell. Source-pull-request: linuxdeepin/dde-session-shell#95
Contributor
Author
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-ci-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideSynchronizes UI-oriented changes from dde-session-shell by adding stable object names and an SPI expected-name manifest across the greeter and session widgets, while extending the blur-background DBus timeout and updating SPDX copyright years. Sequence diagram for extended blur-background DBus timeoutsequenceDiagram
participant Background as FullScreenBackground
participant DBus as ImageEffectDBusService
Background->>DBus: call Get
Note over Background,DBus: Timeout increased to 5 seconds
DBus-->>Background: blurPath
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="src/widgets/fullscreenbackground.cpp" line_range="188" />
<code_context>
DSS_DBUS::imageEffectService, "Get");
message << "" << path;
QDBus::CallMode callMode = isVisible() ? QDBus::BlockWithGui : QDBus::Block;
- QDBusPendingReply<QString> reply = QDBusConnection::systemBus().call(message, callMode, 2 * 1000);
+ QDBusPendingReply<QString> reply = QDBusConnection::systemBus().call(message, callMode, 5 * 1000);
QString blurPath;
</code_context>
<issue_to_address>
**issue (performance):** The synchronous DBus call now blocks the background-update path for up to five seconds instead of two seconds when the image-effect service is slow or unavailable, delaying background updates and making greeter transitions visibly unresponsive.
**Triggers:** When the image-effect DBus service does not answer promptly.
**Suggested fix:** Avoid increasing the synchronous GUI-thread timeout, or issue the DBus request asynchronously and update the background from its completion handler.
</issue_to_address>| DSS_DBUS::imageEffectService, "Get"); | ||
| message << "" << path; | ||
| QDBus::CallMode callMode = isVisible() ? QDBus::BlockWithGui : QDBus::Block; | ||
| QDBusPendingReply<QString> reply = QDBusConnection::systemBus().call(message, callMode, 2 * 1000); |
There was a problem hiding this comment.
issue (performance): The synchronous DBus call now blocks the background-update path for up to five seconds instead of two seconds when the image-effect service is slow or unavailable, delaying background updates and making greeter transitions visibly unresponsive.
Triggers: When the image-effect DBus service does not answer promptly.
Suggested fix: Avoid increasing the synchronous GUI-thread timeout, or issue the DBus request asynchronously and update the background from its completion handler.
Contributor
Author
deepin pr auto review🤖 AI 代码审查报告总体评分： 📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评分： 25/25 ✓ 通过 评价： 语法正确，逻辑清晰 潜在问题： 分析说明：
建议： 无 2. 代码质量 ✅评分： 23/25 ✓ 通过 评价： 代码结构清晰，注释完整 潜在问题：
建议：
分析说明：
3. 代码性能 ✅评分： 20/20 ✓ 通过 评价： 性能良好，资源使用合理 潜在问题： 分析说明：
建议： 无 4. 代码安全 🔒评分： 30/30 ✓ 通过 评价： 存在0个安全漏洞
漏洞对比统计：新增漏洞 0 个，减少漏洞 0 个，持平 0 个 安全漏洞详情： 分析说明：
建议： 无 📋 变更摘要
主要变更内容：
💡 改进建议代码示例// 建议1: 使用更具描述性的对象名称
// 修改前 (auth_single.cpp):
m_lineEdit->setObjectName("LineEdit_2");
// 修改后:
m_lineEdit->setObjectName("AuthSingleLineEdit");
// 建议2: 将 setObjectName 移至循环外部 (controlwidget.cpp)
// 修改前:
while (...) {
// ... 循环体内
m_contextMenu->setObjectName("ContextMenu"); // 冗余调用
}
// 修改后:
m_contextMenu->setObjectName("ContextMenu"); // 移至循环外
while (...) {
// ... 循环体内
}本报告由 AI 代码审查工具自动生成 |
|
TAG Bot New tag: 6.0.68 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronize source files from linuxdeepin/dde-session-shell.
Source-pull-request: linuxdeepin/dde-session-shell#95
Summary by Sourcery
Synchronize session-shell UI updates by standardizing widget identifiers and improving blur-background request reliability.
Bug Fixes:
Enhancements:
Tests: