Skip to content

sync: from linuxdeepin/dde-session-shell - #546

Open
deepin-ci-robot wants to merge 1 commit into
masterfrom
sync-pr-97-nosync
Open

deepin-ci-robot wants to merge 1 commit into
masterfrom
sync-pr-97-nosync

Conversation

@deepin-ci-robot

@deepin-ci-robot deepin-ci-robot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#97

Summary by Sourcery

Synchronize session-shell UI metadata and validation expectations with the upstream implementation.

Enhancements:

  • Add stable Qt object names across greeter, authentication, session-control, plugin, and warning widgets to support UI identification and accessibility tooling.

Tests:

  • Add an expected widget-name mapping for automated SPI/UI validation.

Chores:

  • Synchronize related source updates from dde-session-shell and refresh SPDX copyright years.
  • Remove the obsolete Arabic (Egypt) translation file.

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#97
@deepin-ci-robot

Copy link
Copy Markdown
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Reviewer's Guide

Synchronizes the UI sources with the upstream session-shell change by adding deterministic Qt object names and a comprehensive expected-name manifest for automated SPI/UI validation, while updating SPDX years and removing the obsolete Arabic translation catalog.

File-Level Changes

Change Details Files
Add stable Qt object names across greeter, authentication, gesture, user, session-control, and supporting widgets for UI automation and accessibility-oriented test discovery.
  • Assign descriptive object names to login controls, credential fields, authentication-method buttons, avatars, account controls, floating controls, menus, and warning widgets.
  • Use numbered or dynamic names where multiple instances share a component type, including tray-module buttons and authentication variants.
lighter-greeter/lightergreeter.cpp
plugins/examples/login-plugins/login-basic/login_module.cpp
plugins/examples/login-plugins/login-complex/login-widget.cpp
plugins/examples/login-plugins/login-fullManaged/full_managed_login_widget.cpp
plugins/login-gesture/resetDialog/gesturedialog.cpp
plugins/login-gesture/src/modulewidget.cpp
src/session-widgets/auth_password.cpp
src/session-widgets/auth_single.cpp
src/session-widgets/auth_ukey.cpp
src/session-widgets/auth_widget.cpp
src/session-widgets/sfa_widget.cpp
src/session-widgets/user_widget.cpp
src/session-widgets/userpanel.cpp
src/widgets/controlwidget.cpp
src/widgets/multiuserswarningview.cpp
src/widgets/passworderrortipswidget.cpp
src/widgets/userbutton.cpp
Introduce a source-level expected widget-name manifest to validate synchronization of widget variables, types, object names, and locations.
  • Add YAML expectations covering existing and newly named widgets, including transient and dynamic naming metadata.
  • Keep the manifest empty for QML and transient elements.
tests/at/spi/expected_names.yaml
Refresh SPDX copyright years in synchronized source files and remove an obsolete Arabic translation catalog.
  • Update copyright ranges to include 2026.
  • Delete the Arabic-Egypt translation file.
plugins/examples/login-plugins/login-basic/login_module.cpp
plugins/examples/login-plugins/login-complex/login-widget.cpp
plugins/examples/login-plugins/login-fullManaged/full_managed_login_widget.cpp
plugins/examples/login-plugins/login-udcp/udcp_mfa_login_widget.cpp
plugins/login-gesture/resetDialog/gesturedialog.cpp
plugins/login-gesture/src/modulewidget.cpp
src/session-widgets/auth_widget.cpp
src/session-widgets/sfa_widget.cpp
src/session-widgets/user_widget.cpp
src/widgets/controlwidget.cpp
src/widgets/multiuserswarningview.cpp
src/widgets/passworderrortipswidget.cpp
src/widgets/userbutton.cpp
translations/dde-session-shell_ar_EG.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@deepin-bot

deepin-bot Bot commented Sep 22, 2026

Copy link
Copy Markdown

TAG Bot

New tag: 6.0.68
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant