Batch Script - part 2

[briangoodman]

Lisa,

A followup to the previous batch script:

The original batch script stops execution on an error, so I'm hoping for some suggestions on how to modify the script to continue after an error. Ideally, the modified script would create a text file containing the name of each failed transcode.

The reason for the ask is I'm planning to redo the transcodes of the 2500 original MKV rips I saved over the past decade, and having the script chug along without asking for input to restart seems the only practical way of transcoding such a large volume of MKVs.

Any suggestions would be appreciated.

Regards,

Brian

[lisamelton]

@briangoodman I somehow missed the notification for this when you created it. My apologies!

I know about the bug but I don't have a fix yet. Sorry about that.

[Kerbrer]

Hey, take a look at #384 and see if you can use that as a springboard. Something, something, I have limited knowledge, would like to do something like this too instead of having the whole thing stop but I'm a monkey with a hammer.

[lisamelton]

@Kerbrer I'm looking at it now! Thanks.

[briangoodman]

Thank you!

[lisamelton]

@briangoodman Since @Kerbrer 's script works, do you want to close this now?

[Kerbrer]

#!/usr/bin/env ruby
#
# batch.rb
#

require 'open3'

QUEUE_PATH = 'transcode_queue.txt'
FAILED_LOG_PATH = 'failed_transcodes.log'

loop do
  lines = File.readlines(QUEUE_PATH)
  input = lines.shift
  break if input.nil?
  input = input.chomp
  break if input.empty?

  File.write(QUEUE_PATH, lines.join)

  stderr_lines = []

  status = Open3.popen3('ruby', '-S', 'transcode-video.rb', input, *ARGV) do |stdin, stdout, stderr, wait_thr|
    stdin.close

    threads = [
      Thread.new do
        stdout.each_line do |line|
          if line =~ /^Encoding: task \d+ of \d+/
            print "\r#{line.chomp}#{' ' * 10}"
          else
            puts line
          end
        end
      end,
      Thread.new do
        stderr.each_line do |line|
          $stderr.puts line
          stderr_lines << line.strip unless line.strip.empty?
        end
      end
    ]

    threads.each(&:join)
    wait_thr.value
  end

  result = status.success?

  unless result
    error_message = stderr_lines.reverse.find { |line| line =~ /transcode-video\.rb:\s*(.+)/ }
    error_message = $1 if error_message
    error_message ||= "FAILED (exit status: #{status.exitstatus.inspect})"

    filename = File.basename(input)
    error_message = "#{filename}: #{error_message}" unless error_message.include?(filename)

    File.open(FAILED_LOG_PATH, 'a') do |log|
      log.puts error_message
    end
  end
end

Another one. This one will actually do the output log showing what failures there are and their respective messages, like so:

Supernatural S1E01.mkv: Command failed with exit 1: HandBrakeCLI
scanning media failed: R:\Jellyfin\Serial Images\Supernatural\Season 1\Supernatural S1E02.mkva
Supernatural S1E03.mkv: Command failed with exit 1: HandBrakeCLI

Actually caught myself when copying the script here- I had to rewrite the references to transcode-video.rb so they weren't only pointing to where my specific copy was located. I even got it to work so I don't have to have an empty line at the bottom of the queue anymore.

@lisamelton @briangoodman what do you think?