fix(builder): validate dialect clauses and translate MySQL upserts - #778
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #778 +/- ##
==========================================
+ Coverage 76.96% 77.26% +0.29%
==========================================
Files 487 488 +1
Lines 71929 72084 +155
Branches 10075 10115 +40
==========================================
+ Hits 55361 55695 +334
+ Misses 13149 13115 -34
+ Partials 3419 3274 -145
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
cofin
force-pushed
the
flow/builder-unsupported-clause-errors
branch
from
September 13, 2026 18:05
5b9d12d to
6a031a6
Compare
cofin
added a commit
that referenced
this pull request
Sep 13, 2026
cofin
added a commit
that referenced
this pull request
Sep 13, 2026
cofin
added a commit
that referenced
this pull request
Sep 13, 2026
cofin
added a commit
that referenced
this pull request
Sep 13, 2026
cofin
added a commit
that referenced
this pull request
Sep 13, 2026
Signed-off-by: Cody Fincher <204685+cofin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validates locking and conflict clauses in both
build()andto_statement()and normalizes dialect aliases. Unsupported clauses raiseSQLBuilderErrorinstead of being silently dropped. MariaDB shared locks useLOCK IN SHARE MODE; unsupported lock modifiers are rejected. Spanner's two SQL modes retain plainFOR UPDATEand native upserts, with PostgreSQL-mode assignment restrictions checked.MySQL/MariaDB conflicts translate to
ON DUPLICATE KEY UPDATE, including excluded-value references and DO NOTHING self-assignment. The rewrite preserves the original builder AST and rejects predicates/constraints it cannot preserve. Documentation explains unique-key and trigger differences; regression coverage and v0.63.0 notes are included.Validation:
make lintpassed during review. Regression tests were added or updated, but no local test suite was run in this review. Hosted CI for the latest branch head is still pending.