Skip to content

feat(mssql): align extension stores and document SQL Server workflows - #781

Merged
cofin merged 16 commits into
mainfrom
flow/mssql-integration-alignment
Sep 13, 2026
Merged

cofin merged 16 commits into
mainfrom
flow/mssql-integration-alignment

Conversation

@cofin

@cofin cofin commented Sep 13, 2026

Copy link
Copy Markdown
Member

Adds MssqlPythonADKMemoryStore and SQL Server coverage in shared ADK, event-queue, and Litestar session-store contracts. An additive ADK migration provisions missing memory tables/indexes for existing mssql-python installations and preserves memory data on downgrade. Memory inserts deduplicate concurrent event IDs atomically.

Fixes session-store parameter/binary handling and unsupported queue lock hints. mssql-python ADK JSON storage defaults to NVARCHAR(MAX), retaining an explicit native_json=True override. Adds SQL Server recipes, driver/store documentation corrections, regression coverage, and v0.63.0 release notes.

Validation: make lint passed during review. Regression tests were added or updated, but no local test suite was run in this review. Hosted CI for the latest branch head is still pending.

@cofin cofin changed the title feat(mssql): ecosystem integration alignment, ADK store, and recipes feat(mssql): align extension stores and document SQL Server workflows Sep 13, 2026
@codecov-commenter

codecov-commenter commented Sep 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.69421% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.73%. Comparing base (8547d5d) to head (6afce6c).

Files with missing lines Patch % Lines
sqlspec/adapters/mssql_python/adk/store.py 95.50% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
+ Coverage   76.96%   78.73%   +1.76%     
==========================================
  Files         487      488       +1     
  Lines       71929    72018      +89     
  Branches    10075    10089      +14     
==========================================
+ Hits        55361    56704    +1343     
+ Misses      13149    11827    -1322     
- Partials     3419     3487      +68     
Flag Coverage Δ
integration 62.33% <80.16%> (+3.46%) ⬆️
py3.10 76.85% <90.90%> (+0.40%) ⬆️
py3.11 76.86% <90.90%> (+10.27%) ⬆️
py3.12 66.60% <53.71%> (-9.86%) ⬇️
py3.13 66.60% <53.71%> (+0.01%) ⬆️
py3.14 77.99% <95.04%> (+11.86%) ⬆️
unit 66.94% <53.71%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sqlspec/adapters/mssql_python/adk/__init__.py 100.00% <100.00%> (ø)
sqlspec/adapters/mssql_python/litestar/store.py 82.43% <100.00%> (+29.05%) ⬆️
sqlspec/adapters/pymssql/adk/store.py 71.02% <100.00%> (+35.62%) ⬆️
sqlspec/adapters/pymssql/config.py 96.62% <100.00%> (+1.12%) ⬆️
sqlspec/adapters/pymssql/litestar/store.py 79.72% <ø> (+57.43%) ⬆️
sqlspec/builder/_ddl.py 68.61% <100.00%> (+0.14%) ⬆️
.../adk/migrations/0002_create_mssql_python_memory.py 100.00% <100.00%> (ø)
sqlspec/adapters/mssql_python/adk/store.py 79.60% <95.50%> (+33.74%) ⬆️

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cofin
cofin force-pushed the flow/mssql-integration-alignment branch from ca93d30 to 6efb47d Compare September 13, 2026 18:18
@cofin
cofin merged commit 1e36450 into main Sep 13, 2026
22 of 27 checks passed
@cofin
cofin deleted the flow/mssql-integration-alignment branch September 13, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants