refactor(debloat): execute domain debloat worksheets across builder, core, extensions, infra, and root APIs - #784
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #784 +/- ##
==========================================
+ Coverage 78.90% 78.92% +0.02%
==========================================
Files 491 491
Lines 72443 72316 -127
Branches 10184 10165 -19
==========================================
- Hits 57161 57077 -84
+ Misses 11772 11734 -38
+ Partials 3510 3505 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
cofin
force-pushed
the
flow/domain-debloat
branch
from
September 14, 2026 03:01
a64c15d to
7d1b774
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidate internals, remove obsolete private helpers, hoist call-time constants, and streamline module structures across builder, core, driver/adapters, extensions, infrastructure, and root APIs without altering public contracts or runtime behavior.
Changes
Builder:
_expected_result_typedeclarations and unusedSQLResultimports.expr_eq,expr_neq,expr_gt,expr_gte,expr_lt,expr_lte,expr_not_like) fromsqlspec.core.query_modifiers; simplified_handle_not_in_operatorto wrap_handle_in_operatorinexp.Not.expr_type_mapidentity map inSQLFactory.__call__; narrowed internal_factory.pyexport list; reordered public factory and COPY API before call-time helpers.Finalconstants; removed redundantSPANNER_DIALECTSbranch in EXPLAIN rendering.Dialectimport in_locking.py.ReturningClauseMixinfrom_select.pyto_dml.py, preserving canonical package re-exports.Core & Driver/Adapters:
_processor._coerce_parameter_types; hoistedSQLSpecErrorimport and shared missing parameter validation logic across single and batch parameter mappings._EXPANDING_POSITIONAL_STYLESconstant in_types.pyfor processor and converter while keeping_OCCURRENCE_KEYED_STYLESdistinct._transform_cached_parameterstotransform_cached_parametersacross compiler, statement, driver, and tests._resolve_log_adapterand trivial forwarder_needs_coercion_candidatein_common.py._update_dialect_for_extensionsin ADBC config and migrated tests to runtime extension state resolution.sqlspec.core.config_runtime.last_cursoralias in SQLite driver and hoistedconnection.executeerror mapping before query branching._ = kwargsplaceholder and narration comments.Extensions (ADK):
_require_enabled,_effective_limit, and_log_operationhelpers from memory store._new_idhelper and itsuuid4import from BigQuery ADK store.datetime, timezoneimports to module level.Infrastructure & CLI:
_sql_resource_root,_output_warning, and_column_exists_query.cli.pyshared by upgrade and downgrade commands.migrations/commands.py.importlibindialects/__init__.py; cleaned UUID and serializer imports in utilities.Root API:
loader.pyparameter declaration parsing after value objects; grouped publicSQLFileLoadermethods before private helpers.service.pytransaction helpers after public service classes.config.pymigration key validation before runtime-only helpers.typing.pyoptional loader imports toutils.module_loader.Verification
make lint: clean exit 0 (Prek, Ruff check, Ruff format, slotscheck, Mypy, Pyright, Zizmor).