fix(service): preserve slotted service subclasses with compiled core runtime - #785
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #785 +/- ##
==========================================
- Coverage 78.93% 78.93% -0.01%
==========================================
Files 491 493 +2
Lines 72316 72337 +21
Branches 10165 10165
==========================================
+ Hits 57081 57096 +15
- Misses 11730 11736 +6
Partials 3505 3505
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep
SQLSpecAsyncServiceandSQLSpecSyncServiceas ordinary slotted Python classes insqlspec.service._basewhile retaining compiled query execution and transaction helpers in the privatesqlspec.service._coreruntime. Downstream consumers and frameworks (such as Litestar and Advanced Alchemy) preserve generic typing and__slots__without native class layout restrictions or slotscheck exclusions.Changes
sqlspec/service/):sqlspec/serviceinto a package with explicit re-exports in__init__.py.sqlspec/service/_base.pyas pure slotted Python classes (excluded from mypyc compilation).sqlspec/service/_core.py(compiled viahatch-mypyc).sqlspec/driver/.tools/scripts/mypyc_smoke.pyandtools/scripts/mypyc_inventory.py) testing multi-level slotted subclasses, transaction contexts, and session acquisition.