Restore explicit self in the AsyncCompleter timeout block - #1130
Merged
Merged
Conversation
#1124 rewrote this line from `self._entries[entryId]` to an implicit `_entries`. SPM builds in Swift 6 language mode, which accepts implicit self in a nested closure after `[weak self]` / `guard let self`; the podspec pins `swift_versions = ["5.9"]`, and Swift 5 mode rejects it. CocoaPods Lint has been red on every run since. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
pblazej
requested review from
hiroshihorie and
xianshijing-lk
as code owners
September 16, 2026 12:19
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
hiroshihorie
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CocoaPods Lint, red on every run since #1124 replaced
self._entrieswith an implicit_entries— legal in the Swift 6 language mode SPM builds with, rejected by the Swift 5 mode the podspec pins viaswift_versions = ["5.9"].