Skip to content

Release packages - #1455

Open
knope-bot[bot] wants to merge 1 commit into
mainfrom
knope/release
Open

knope-bot[bot] wants to merge 1 commit into
mainfrom
knope/release

Conversation

@knope-bot

@knope-bot knope-bot Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Important

Merging this pull request will create these releases

livekit 0.9.3 (2026-09-24)

Fixes

livekit-token 0.2.1 (2026-09-24)

Fixes

livekit-signaling 0.1.4 (2026-09-24)

Fixes

livekit-datatrack 0.2.1 (2026-09-24)

Fixes

livekit-api 0.8.1 (2026-09-24)

Fixes

libwebrtc 0.3.50 (2026-09-24)

Fixes

livekit-uniffi 0.2.1 (2026-09-24)

Fixes

livekit-common 0.1.4 (2026-09-24)

Fixes

livekit-ffi 0.12.81 (2026-09-24)

Fixes

Export SoxResampler through UniFFI

SoxResampler is now a UniFFI object, so foreign hosts can construct one and
drive push / flush directly, receiving the resampled samples by value.

The FFI request surface is unchanged: NewSoxResampler, PushSoxResampler and
FlushSoxResampler still hand back a pointer into the resampler's own buffer,
readable until the next call on that resampler. Both paths are covered by new
tests that drive them with the same input and compare the results.

livekit-data-stream 0.1.7 (2026-09-24)

Fixes

livekit-protocol 0.8.0 (2026-09-24)

Breaking Changes

livekit-capture 0.1.3 (2026-09-24)

Fixes

webrtc-sys 0.3.47 (2026-09-24)

Fixes

livekit-rpc 0.1.3 (2026-09-24)

Fixes

@knope-bot
knope-bot Bot requested a review from ladvoc as a code owner September 23, 2026 11:33

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@knope-bot
knope-bot Bot requested a review from cloudwebrtc as a code owner September 23, 2026 13:36
@knope-bot
knope-bot Bot requested a review from lukasIO as a code owner September 24, 2026 13:05
1egoman added a commit that referenced this pull request Sep 24, 2026
…vekit-protocol release (#1464)

Fixes #1461.

## The bug

`.changeset/upgrade_to_prost_0_14_across_the_whole_project.md` lists
`livekit-uniffi: patch` **twice**. The second one was appended by
a65fe9d ("fix: upgrade livekit-uniffi prost 0.12 straggler") to a list
that already had it.

Knope cannot parse front matter with a duplicate key — it fails the
whole file:

```
Running step PrepareRelease(...)
Error: changesets::could_not_read_changeset
  × invalid front matter
```

The Knope Bot swallows that error and regenerates the release PR from
the *remaining* changesets. There is no comment and no failing check —
the release PR just quietly omits every package the file was supposed to
bump. Verified by dry-running knope 0.23.0 against a worktree of `main`:
moving this one file out reproduces the contents of #1455 exactly, which
contains no `livekit-protocol`.

## Why it shipped a broken crate

The prost changeset has had no effect since #1447 merged, so
`livekit-protocol` stayed at 0.7.13 (prost `^0.12`). But the prost 0.14
source was on `main`, and `livekit-data-stream` got a patch bump from an
unrelated changeset (`reliable-dc-replay`) in release PR #1423. So 0.1.6
went to crates.io as:

| crate | published | `prost` | `livekit-protocol` |
|---|---|---|---|
| livekit-protocol 0.7.13 | 2026-09-08 | `^0.12` | — |
| livekit-data-stream 0.1.5 | 2026-09-09 | `^0.12` | `^0.7.13` |
| **livekit-data-stream 0.1.6** | **2026-09-23** | **`^0.14`** |
`^0.7.13` |

Two prost versions in one graph, which is the `E0599: no method named
encoded_len` in #1461.

## The fix

Remove the duplicate line. `knope release --dry-run` then succeeds and
produces:

```
webrtc-sys = 0.3.47, livekit-protocol = 0.8.0, livekit-api = 0.8.1,
livekit-token = 0.2.1, livekit-signaling = 0.1.4, libwebrtc = 0.3.50,
livekit = 0.9.3, livekit-ffi = 0.12.81, livekit-uniffi = 0.2.1,
livekit-datatrack = 0.2.1, livekit-common = 0.1.4, livekit-data-stream = 0.1.7,
livekit-rpc = 0.1.3, livekit-capture = 0.1.3
```

Once this lands the bot will regenerate #1455 with `livekit-protocol`
0.8.0 included, and merging that unblocks the reporter.

I checked the changeset's package list is complete for a breaking
`livekit-protocol` bump: the only crates left out of that set —
`livekit-net`, `livekit-region`, `livekit-token-source`,
`livekit-wakeword`, `device-info` — reach neither `livekit-protocol` nor
any other bumped crate.

## Follow-up (not in this PR)

`.github/workflows/changeset-check.yml` already guards against knope's
other silent-ignore case (quoted package names, #1411), but not
duplicate keys — which is worse, since it discards the whole file rather
than one line. Worth adding to `changeset_detect.py`.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
@knope-bot
knope-bot Bot requested a review from 1egoman as a code owner September 24, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants