Resolve mlir_runner_utils on Darwin via .dylib extension - #268
Closed
FedericoBruzzone wants to merge 2 commits into
Closed
Resolve mlir_runner_utils on Darwin via .dylib extension#268FedericoBruzzone wants to merge 2 commits into
mlir_runner_utils on Darwin via .dylib extension#268FedericoBruzzone wants to merge 2 commits into
Conversation
Signed-off-by: Federico Bruzzone <federico.bruzzone.i@gmail.com>
Signed-off-by: Federico Bruzzone <federico.bruzzone.i@gmail.com>
Member
|
Can you just merge this with the previous PR? Should be a trivial change. |
Member
Author
Sure, thank you. I'll update the other PR description :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After running
uv run lit .after #267 one test still fails:The problem is relatively simple to fix. Currently,
lighthouseassumes a.soextension for shared libs. Unfortunately, on macOS the extension is.dylib. This PR introduces the_SHARED_EXTvar to handle it properly.Any feedback is welcome :D
Stacked on: #267