Skip to content

Resolve mlir_runner_utils on Darwin via .dylib extension - #268

Closed
FedericoBruzzone wants to merge 2 commits into
llvm:mainfrom
FedericoBruzzone:arm64-fix-2
Closed

Resolve mlir_runner_utils on Darwin via .dylib extension#268
FedericoBruzzone wants to merge 2 commits into
llvm:mainfrom
FedericoBruzzone:arm64-fix-2

Conversation

@FedericoBruzzone

Copy link
Copy Markdown
Member

After running uv run lit . after #267 one test still fails:

Failed Tests (1):
  Lighthouse test suite :: test/run/pipeline-check.mlir

The problem is relatively simple to fix. Currently, lighthouse assumes a .so extension for shared libs. Unfortunately, on macOS the extension is .dylib. This PR introduces the _SHARED_EXT var to handle it properly.

Any feedback is welcome :D

Stacked on: #267

Signed-off-by: Federico Bruzzone <federico.bruzzone.i@gmail.com>
Signed-off-by: Federico Bruzzone <federico.bruzzone.i@gmail.com>
@FedericoBruzzone

FedericoBruzzone commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

P.S. I'll rebase as soon as #267 is merged to make the review process smooth. However, the new changes are isolated in 91f515d .

@rengolin @adam-smnk

@rengolin

Copy link
Copy Markdown
Member

Can you just merge this with the previous PR? Should be a trivial change.

@FedericoBruzzone

Copy link
Copy Markdown
Member Author

Can you just merge this with the previous PR? Should be a trivial change.

Sure, thank you. I'll update the other PR description :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants