[Linalg][Transform] An Approach for Tiling and Fusing Dependent Reductions in Linalg - #274
Open
charithaintc wants to merge 6 commits into
Open
[Linalg][Transform] An Approach for Tiling and Fusing Dependent Reductions in Linalg#274charithaintc wants to merge 6 commits into
charithaintc wants to merge 6 commits into
Conversation
…d Fusing Dependent Reductions in Linalg" Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
cc @tkarna |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the lighthouse-based implementation of the [Linalg][RFC] An Approach for Tiling and Fusing Dependent Reductions in Linalg.
The proposed
structured.fuse_dependent_reduction_opis implemented as lighthouse transform extension. Major difference in the implementation include re-implementing IR utilities that are not available in python bindings (like thescf::tileAndFuseConsumer).Fused attention example and nanoGPT examples are modified to use the new fusion extension. PR also provides isolated tests for the transform extension inside
test/transform/test_fuse_dependant_reduction_ops.py. Implementation can be extended to other intricate usecases as the needs evolve.Preliminary performance looks encouraging. Fused attention automatic fusion can match the hand-written version. For the time being I did not remove the hand-written fused loop emission path (available via
--reference-flashflag)On PVC:
Assisted by: Claude