Add pack_, pack_clamp_ and unpack_ tests - #1432
Merged
Merged
Conversation
Adds tests covering a matrix of signed, unsigned, 16, and 32 bit pack, pack_clamp, and unpack intrinsics.
kmpeng
reviewed
Aug 21, 2026
Alexander-Johnston
force-pushed
the
pack_unpack
branch
from
September 14, 2026 22:41
5385289 to
cb38bfc
Compare
kmpeng
reviewed
Sep 15, 2026
kmpeng
reviewed
Sep 17, 2026
This was
linked to
issues
Sep 17, 2026
Closed
Closed
kmpeng
reviewed
Sep 22, 2026
kmpeng
approved these changes
Sep 22, 2026
kmpeng
left a comment
kmpeng
left a comment
Contributor
There was a problem hiding this comment.
LGTM, will get you another reviewer.
llvm-beanz
approved these changes
Sep 22, 2026
Contributor
|
@Alexander-Johnston Good to go! Do you need someone to merge this in for you? |
Collaborator
Author
Yes, if you could @kmpeng that would be superb. Thanks for the patience while I made a right pigs ear of this one! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests covering a matrix of signed, unsigned, 16, and 32 bit pack, pack_clamp, and unpack intrinsics.
As the intrinsics/tests are all simple in nature and related in function, I've packaged together all of the pack and unpack variants.
Closes #863, #864, #865, #866, #891, #892, #893, #894,