Add sign matrix tests - #1489
Merged
Merged
Conversation
Closes llvm#793 Adds matrix tests for sign covering 32 bit float, int, and uint. Only testing 32 bit element types because the matrix-specific lowering is independent of element width on both DXIL and SPIR-V backends, and the behavior of sign on 16 and 64 bit types is already covered well by the existing scalar/vector tests.
kmpeng
self-requested a review
September 4, 2026 23:31
Contributor
Author
|
Sorry, I see that I've failed CI a couple of times because XFAILs on unrelated tests had gone stale on my branch. I'll try to keep my branch updated daily from now on, my bad. |
Contributor
|
@djb No need to always keep the branch updated! As long as you make sure the tests touched by your PR aren't failing and there aren't merge conflicts, that's good. Also sorry I haven't reviewed this yet, I've been out sick. Will try to get to it today. |
kmpeng
approved these changes
Sep 10, 2026
bogner
approved these changes
Sep 10, 2026
Contributor
Author
|
Thanks for the reviews! @kmpeng Got it. Yes, please, if you could merge it for me that would be great, thanks. Hope that you are feeling all better soon! |
Alexander-Johnston
pushed a commit
to Alexander-Johnston/offload-test-suite
that referenced
this pull request
Sep 14, 2026
Closes llvm#793 Add matrix tests for `sign` covering 32 bit `float`, `int`, and `uint`. Only testing 32 bit element types because the matrix-specific lowering is independent of element width on both DXIL and SPIR-V backends, and the behavior of `sign` on 16 and 64 bit types is already covered well by the existing scalar/vector tests. Assisted-by: GPT 5.6 Sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #793
Add matrix tests for
signcovering 32 bitfloat,int, anduint.Only testing 32 bit element types because the matrix-specific lowering is independent of element width on both DXIL and SPIR-V backends, and the behavior of
signon 16 and 64 bit types is already covered well by the existing scalar/vector tests.Assisted-by: GPT 5.6 Sol