Update InterlockedExchange clang implementation xfails - #1536
Merged
Merged
Conversation
hekota
approved these changes
Sep 25, 2026
llvm-beanz
reviewed
Sep 25, 2026
| # REQUIRES: Float32GroupSharedAtomics | ||
|
|
||
| # Unimplemented: https://github.com/llvm/llvm-project/issues/99129 | ||
| # XFAIL: Clang |
Contributor
There was a problem hiding this comment.
This test seems to still be failing with Clang.
Contributor
Author
There was a problem hiding this comment.
Yes, we will need this PR to merge before this test can start to pass:
llvm/llvm-project#226563
Contributor
There was a problem hiding this comment.
The normal flow in the team has been merge the LLVM PR, then merge the offload-test-suite PR.
I kinda don't care which order we go in, but one of them needs to go in first, and the second should quickly follow. We can't just leave these broken for weeks.
In either case if you're merging a PR that has red status checks and asking for review approval to do it you should explain why so that reviewers can verify that the failing builds are expected.
…om/bob80905/offload-test-suite into remove_interxchg_xfails_clang_impl
kmpeng
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the XFAILS for the InterlockedExchange tests, now that the associated PRs for implementation went in.