Drop clang implementation XFAILS for compare* offload tests - #1545
Merged
bob80905 merged 6 commits intoOct 1, 2026
Merged
Conversation
bob80905
marked this pull request as draft
September 29, 2026 19:52
bob80905
marked this pull request as ready for review
September 29, 2026 20:50
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 31a05c1a-5964-44c7-8232-fafe7d978d6b
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 31a05c1a-5964-44c7-8232-fafe7d978d6b
damyanp
reviewed
Sep 30, 2026
Comment on lines
+312
to
316
| # Bug: https://github.com/llvm/llvm-project/issues/227531 | ||
| # XFAIL: Clang && (DirectX || Metal) | ||
| # Bug: https://github.com/llvm/llvm-project/issues/227064 | ||
| # XFAIL: Clang && Vulkan | ||
| # RUN: split-file %s %t |
Contributor
There was a problem hiding this comment.
nit: somespacingmighthelpmakethiseasiertoread
Suggested change
| # Bug: https://github.com/llvm/llvm-project/issues/227531 | |
| # XFAIL: Clang && (DirectX || Metal) | |
| # Bug: https://github.com/llvm/llvm-project/issues/227064 | |
| # XFAIL: Clang && Vulkan | |
| # RUN: split-file %s %t | |
| # Bug: https://github.com/llvm/llvm-project/issues/227531 | |
| # XFAIL: Clang && (DirectX || Metal) | |
| # Bug: https://github.com/llvm/llvm-project/issues/227064 | |
| # XFAIL: Clang && Vulkan | |
| # RUN: split-file %s %t |
| # REQUIRES: Int64 && SM_6_6 && (!Vulkan || VulkanInt64BufferAtomics) | ||
| # Bug: https://github.com/llvm/llvm-project/issues/227531 | ||
| # XFAIL: Clang && (DirectX || Metal) | ||
| # Bug: https://github.com/llvm/llvm-project/issues/227064 |
Contributor
There was a problem hiding this comment.
227064 is "Pointer-cast legalization crashes on constant groupshared array access", but there are no groupshared arrays in this test (and I think in the others as well). In fact, this test file explicitly says it is for the non-groupshared case. Are you sure this is the right bug to link to?
The compare tests hit SPIRVLegalizePointerCast.cpp:819 with 'Unsupported ptrcast user', which is issue 221370. Issue 227064 is a different crash at line 257. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 31a05c1a-5964-44c7-8232-fafe7d978d6b
hekota
approved these changes
Sep 30, 2026
llvm-beanz
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last 4 interlocked PRs in the llvm-repo are merged:
llvm/llvm-project#222164
llvm/llvm-project#222165
llvm/llvm-project#222166
llvm/llvm-project#222167
So, the associated xfails for unimplemented in clang should be removed.
Assisted by: Github Copilot