Update WaveActiveBallot.Wave32.test and WaveActiveBallot.Wave64.test - #697
Merged
Merged
Conversation
tcorringham
force-pushed
the
active-ballot
branch
from
February 10, 2026 15:37
2ddb5c1 to
b9da42e
Compare
farzonl
reviewed
Feb 13, 2026
| @@ -1,59 +1,56 @@ | |||
| #--- source.hlsl | |||
| RWStructuredBuffer<uint4> Out : register(u1); | |||
|
|
|||
Member
There was a problem hiding this comment.
Github diff isn't great here. I think you are removing CRLF from this file but just want you to confirm.
I'm running your patch through sed and thats what seems to be going on.
curl -L https://patch-diff.githubusercontent.com/raw/llvm/offload-test-suite/pull/697.patch | sed -n 'l'
-# RUN: %offloader %t/pipeline.yaml %t.o\r$
+# RUN: %offloader %t/pipeline.yaml %t.o$
farzonl
added
the
test-all
farzonl
approved these changes
Feb 13, 2026
farzonl
left a comment
farzonl
left a comment
Member
There was a problem hiding this comment.
You will need to force push or rebase to kick off the amd runner. as this pr didn't have the test-all label.
PR it self LGTM.
tcorringham
force-pushed
the
active-ballot
branch
from
March 3, 2026 11:40
16e8efd to
e4ca8f7
Compare
The Output buffer stride for WaveActiveBallot.Wave32.test and WaveActiveBallot.Wave64.test was set to 4, but the buffer holds uint4 elements so requires a stride of 16 (4 * 4). With the amended stride these now pass on AMD DXIL so the XFAIL has been removed.
tcorringham
force-pushed
the
active-ballot
branch
from
March 10, 2026 15:51
76f5fbe to
8e59262
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Output buffer stride for WaveActiveBallot.Wave32.test and WaveActiveBallot.Wave64.test was set to 4, but the buffer holds uint4 elements so requires a stride of 16 (4 * 4).
With the amended stride these now pass on AMD DXIL so the XFAIL has been removed.
Fixes #688