fix Transfer-Encoding behavior in input for SimpleRequestsClient#39
Merged
Conversation
alexrashed
approved these changes
Jun 11, 2026
alexrashed
left a comment
Member
There was a problem hiding this comment.
Great change, great tests, great PR description outlining the changes and referring the spec! 🤩 ![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This was reported in https://github.com/orgs/localstack/discussions/35
We were forwarding the
Transfer-Encodingheader back to the server, even though it is a hop-by-hop server. We have done a lot of work already to remove it from responses, but we did not do it in theSimpleRequestsClientIt was however done in the
Proxya while back.See
hop-by-hopheaders: https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/HeadersChanges
Transfer-Encodingheader which shouldn't be forwarded