[CI] Expect real response durations in the request specs - #66
Merged
Merged
Conversation
logtail-rack 0.2.8 times responses with the monotonic clock, which Timecop doesn't freeze, so "Completed 200 OK in 0.0ms" no longer holds. The last CI run on main still resolved logtail-rack 0.2.7. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PetrHeinz
marked this pull request as ready for review
October 2, 2026 08:51
PetrHeinz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on
mainhas been red since logtail-rack 0.2.8 was released. The latestbuildrun onmain(https://github.com/logtail/logtail-ruby-rails/actions/runs/36985106168) failed on all 65 jobs. Each job failed the same three examples:spec/logtail-rails/http_events_spec.rb:38spec/logtail-rails/http_events_spec.rb:81spec/logtail-rails/rack_logger_spec.rb:38logtail-rack 0.2.8 times responses with the monotonic clock. Timecop doesn't freeze that clock, so the response line now reads e.g.
Completed 200 OK in 0.7msinstead ofin 0.0ms. The last green run onmainstill resolved logtail-rack 0.2.7.This PR only changes the tests: the three expectations now match any one-decimal duration (
in \d+\.\d+ms), which also still matches 0.2.7's0.0ms. The gem code is unchanged, so no release is needed.The open logtail-rails PRs (#59–#65) each carry this same commit, so the patches are identical and they will merge cleanly after this one.
Locally on Rails 8.1 / Ruby 3.4.9 with logtail-rack 0.2.8: 36 examples, 0 failures.
🤖 Generated with Claude Code