Support Ruby 4.0 and TruffleRuby 40: declare the logger dependency - #46
Merged
Merged
Conversation
Expected to fail, like the truffleruby job already does: logger is no longer a default gem there and logtail does not declare it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Ruby 4.0 and TruffleRuby 40 no longer ship logger as a default gem, so under Bundler `require "logtail"` raised a LoadError unless the app bundled logger itself. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Nothing in the gem uses Base64. base64 stopped being a default gem in Ruby 3.4, so the require alone broke apps that do not bundle it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby 4.0 and TruffleRuby 40 no longer ship
loggeras a default gem, so under Bundlerrequire "logtail"raisescannot load such file -- loggerunless the app happens to bundle it. That is why thetrufflerubyjob is red onmain, and Ruby 4.0 was not in the matrix at all.loggeris now a runtime dependency of the gem.require "base64"is gone. Nothing in the gem usesBase64, and since Ruby 3.4 the require alone broke apps that do not bundlebase64. The Gemfile still bundles it for the test dependencies.The first commit only adds Ruby 4.0 to the matrix and is red on the
4.0andtrufflerubyjobs. With the following commits the whole matrix is green.The rack and rails gems pick the dependency up with the next
logtailrelease.🤖 Generated with Claude Code