ci: run on Node 22 - #13
Merged
Merged
Conversation
Node 20 was already below what parts of the tree ask for: rolldown, which Vite 8 pulls in through the SvelteKit test app, declares engines node >=22. GitHub also now forces actions/checkout, actions/setup-node and pnpm/action-setup onto Node 24 with a deprecation warning, so the runner was diverging from the version the jobs actually used. The published packages keep their own engines ranges (>=18 for @logtide/cli, >=20 for @logtide/sdk-node): this changes what CI runs on, not what consumers need.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
NODE_VERSIONfrom20to22inci.ymlandpublish.yml.Node 20 was already below what parts of the dependency tree ask for:
rolldown, which Vite 8 pulls in through the SvelteKit test app, declaresengines: node >=22. GitHub also now forcesactions/checkout,actions/setup-nodeandpnpm/action-setuponto Node 24 with a deprecation warning, so the runner was diverging from the version the jobs actually used.No
enginesfield changes: the published packages keep>=18(@logtide/cli) and>=20(@logtide/sdk-node). This changes what CI runs on, not what consumers need.Worth noting separately: CI exercises a single Node version, so those
enginesclaims stay untested. A version matrix would be a bigger change than this one and is not included here.🤖 Generated with Claude Code