fix(log-viewer): keep a find match's panel up, and make a highlighted frame read on any theme - #6
Closed
lukecotter wants to merge 2 commits into
Closed
lukecotter wants to merge 2 commits into
lukecotter wants to merge 2 commits into
Conversation
Stepping to a match centres the view, and the render that moves the frames asks the hit test again at the pointer. That answer took the match's own panel away, so the panel showed only when the pointer happened to rest off the chart. The chart now reports what changed the hover, and a panel opened by find or by the keyboard is held until the pointer moves or something else closes it.
The highlight takes its colour from the host's `editor.findMatchBackground`, a grey in several themes, and a search dims the frames around a match towards grey too, so the match could be lost among them. A frame too brief to carry a border got no border at all, leaving a hairline. Every highlight now carries a halo in the tone its colour is not, and a frame too thin to border is bordered at the width the wash widened it to. Both hairlines sit inside the frame's own row.
6 tasks
Owner
Author
|
Moved to certinia#1059. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red. The web e2e times out after 7m46s on every run since certinia#1029 merged — see the failure on certinia#1042.Cause
certinia#1029 provisions Salesforce Services from a local unpacked copy when it finds one, and falls back to the gallery id when it does not. A CI runner has no local copy, so it always takes the fallback.
@vscode/test-webpushesextensionIdsintoadditionalBuiltinExtensionsas a gallery reference (workbench.js:135-139), so the browser resolves it from the publisher CDN — which sends noAccess-Control-Allow-Originto alocalhostorigin. Services therefore sits atActivatingfor good, andwaitForExtensionsActivatedwaits out its full 120s, three times over with retries.That fallback never worked; it was hidden.
createWebConfigpasses--disable-web-security, which allowed the cross-origin fetch. The same PR dropped that flag so the suite could see CORS and CSP faults — which is exactly what it then saw, on a fault that was already there.Fix
Provision Services when a local unpacked copy exists, and otherwise not at all.
Nothing is lost. No spec needs Services today:
initServices()is called lazily from org commands, and no spec exercises one. The gallery route cannot work from alocalhostorigin whatever we do, so keeping it as a "fallback" only buys a guaranteed 120s hang.Verified
Forced the CI condition locally by making
findServicesExtension()return nothing, and ran the suite on the merged code and on this fix:tsc -b0,eslint0 errors, prettier clean.