Skip to content

fix(cursor): retain adjacent mid-stream echo diagnostics - #380

Closed
luvs01 wants to merge 2 commits into
devfrom
codex/propose-fix-for-echo-marker-overwrite-issue
Closed

luvs01 wants to merge 2 commits into
devfrom
codex/propose-fix-for-echo-marker-overwrite-issue

Conversation

@luvs01

@luvs01 luvs01 commented Aug 31, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The mid-stream echo observer used a single pending corruptionWatch which could be overwritten by a later marker inside the 512-character corruption window, losing earlier findings and their accumulated corruption evidence.

Description

  • Replace the single corruptionWatch with a bounded array corruptionWatches to track multiple concurrent pending watches and preserve up to MAX_MIDSTREAM_FINDINGS findings. (edited src/adapters/cursor/envelope-echo.ts).
  • Apply incoming text to every active corruption watch and settle any watches whose window has been filled, pushing their boolean corruption result into recorded and removing the settled watch. (edited src/adapters/cursor/envelope-echo.ts).
  • Adjust the findings() path to flush all remaining pending watches before returning recorded findings. (edited src/adapters/cursor/envelope-echo.ts).
  • Update and add regression tests that assert closely spaced markers both survive and retain correct offsets and corruption flags. (edited tests/cursor-envelope-echo-retry.test.ts).

Testing

  • ✅ Ran the focused suite bun test tests/cursor-envelope-echo-retry.test.ts, and the updated tests passed.
  • ✅ Ran bun run typecheck which completed successfully.
  • ✅ Ran bun run privacy:scan which completed successfully.
  • ⚠️ Ran the full repository test run (bun run test) but it encountered numerous unrelated timeouts and shared-state failures outside the modified Cursor observer code; those failures are existing, unrelated CI-scale issues and were not caused by this focused change.

Codex Task


Devin Review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-31T00:49:48.828041Z 87b2ab0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 31, 2026
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository: luvs01/opencodex/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 1f2ffd77-a04e-464e-840b-58849e8368f4


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown

✅ READY

  • all PR quality gates passed.

Hygiene

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot changed the title fix(cursor): retain adjacent mid-stream echo diagnostics [WRONG BRANCH] fix(cursor): retain adjacent mid-stream echo diagnostics Aug 31, 2026
@github-actions
github-actions Bot marked this pull request as draft August 31, 2026 00:47
@luvs01 luvs01 changed the title [WRONG BRANCH] fix(cursor): retain adjacent mid-stream echo diagnostics fix(cursor): retain adjacent mid-stream echo diagnostics Sep 3, 2026
@luvs01
luvs01 changed the base branch from main to dev September 3, 2026 06:23
@github-actions
github-actions Bot marked this pull request as ready for review September 3, 2026 06:32

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

luvs01 added a commit that referenced this pull request Sep 21, 2026
… reasoning quarantine

Combines two fork PRs touching envelope-echo: retain adjacent mid-stream echo diagnostics (#380) and bound the output-guard reasoning quarantine (#347), rebased onto current dev.

bun test cursor-envelope-echo-retry + cursor-adapter + cursor-tool-continuation: 101 pass
@luvs01

luvs01 commented Sep 21, 2026

Copy link
Copy Markdown
Owner Author

Closing: superseded by combined PR #610, which carries this PR's adjacent mid-stream echo diagnostics retention together with the bounded reasoning-quarantine change on current dev. Combined tests: 47 + 54 pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant