Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: luvs01/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
✅ READY
Hygiene✅ Deterministic PR hygiene checks passed. |
Co-Authored-By: Epinephrine <luvs01@hanmail.net>
|
Fixed in dd078ab. Each rotation action is now gated by its own handler, and the section renders only when the selected key's state has a wired action — |
…tions A start-only caller's successful rotation flips selectedRotationId truthy, which switched the section guard to commit/abort and unmounted the reveal — stranding the one-time secret. Treat a matching rotationSecret as its own reason to render, and wire Copy/Close to their optional callbacks instead of always drawing them. Adds a rerender test for the start->secret flow and coverage for the secret controls' independent gating. Co-Authored-By: Epinephrine <luvs01@hanmail.net>
|
Fixed in bed96dd. A matching |
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Motivation
Description
rotationEnabledguard computed fromonRotationStart,onRotationCommit, oronRotationAbortand use it to conditionally render the rotation section inApiKeysWorkspace(gui/src/components/apikeys-workspace/ApiKeysWorkspace.tsx).runRotationhelper unchanged so rotation behavior remains identical when handlers are present.gui/tests/apikeys-actions.test.tsx).UI screenshot
Testing
cd gui && bun test tests/apikeys-actions.test.tsx, which passed (including the new test).cd gui && bun run lintandcd gui && bun run build, both succeeded for the changed code path.bun run typecheckandbun run privacy:scan, both succeeded for the modified files.Codex Task
Link to Devin session: https://app.devin.ai/sessions/c66f906db0b04a40940502baa5f0115e
Open in Devin Desktop: https://app.devin.ai/desktop/session/c66f906db0b04a40940502baa5f0115e?variant=devin