Conversation
…forwarded role (lidge-jun#5334 follow-up) lidge-jun#5334 made the developer wire role tri-state: an undeclared destination folds it to system. Two suites asserting role:"developer" on the Chat wire were missed because they are about tool-result repair ordering and document parts, not role selection — declare the destination, per the convention the change established. Verified: both files fail on dev@600075d2 with system-for-developer wire roles and pass with the declaration. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: luvs01/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…pair Co-Authored-By: Epinephrine <luvs01@hanmail.net>
|
Fixed in 67ccd8d — |
1 similar comment
|
Fixed in 67ccd8d — |
Motivation
function_call_output/custom_tool_call_outputitems to be rewritten into user messages when the matchingfunction_callstill lived upstream behindprevious_response_id.Description
repairOrphanedInputItemsby introducing arepairOrphanOutputsparameter so orphan-output-to-user-message conversion can be toggled, and preserve the original signature-compatible behavior when enabled (src/adapters/openai-responses/tool-output-recovery.ts).repairOrphanedInputItemswithrepairOrphanOutputsenabled only when appropriate (forward or stateless wires, or when there is no unexpandedprevious_response_id) (src/adapters/openai-responses/passthrough.ts).tests/providers/xai/xai-responses-adjacency.test.ts).structure/providers/chat-compat.md).Testing
bun test tests/providers/xai/xai-responses-adjacency.test.tsand related focused dangling-call suites; the focused set passed (8–25 tests depending on scope) on the repo Bun (node_modules/bun/bin/bun.exev1.4.0).bun x tsc --noEmitand structure SSOT checks withbun run structure:check; both succeeded.tests/providers/xai/xai-responses-adjacency.test.ts,tests/responses/responses-forward-dangling-call.test.ts, andtests/responses/responses-stateless-dangling-call-repair.test.ts; these passed end-to-end in the environment used.bun run testin this container showed unrelated environment/timing/process-group flakes in other suites; the changes in this PR are covered by the focused tests which passed.Codex Task