Conversation
…forwarded role (lidge-jun#5334 follow-up) lidge-jun#5334 made the developer wire role tri-state: an undeclared destination folds it to system. Two suites asserting role:"developer" on the Chat wire were missed because they are about tool-result repair ordering and document parts, not role selection — declare the destination, per the convention the change established. Verified: both files fail on dev@600075d2 with system-for-developer wire roles and pass with the declaration. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: luvs01/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
Motivation
writeFileSync, which allowed a same-UID attacker to pre-position a symlink and have the test overwrite an arbitrary target.Description
tests/helpers/fixture-file-publisher.tsprovidingpublishFixtureFile(path, content)that creates the temp file withopenSync(..., "wx", 0o600), verifies descriptor vs directory-entry identity viafstatSync/lstatSync, writes through the verified descriptor, closes it, and thenrenameSyncs into place.tests/helpers/native-profile-startup-child.tswith an import and uses ofpublishFixtureFilefor both the port and settled marker publications.tests/codex-integration/native-profile-startup-publication.test.tsthat pre-creates a PID-derived.tmpsymlink and assertspublishFixtureFilethrows and does not clobber the symlink target.scripts/test-layout/layout.jsonandtests/fixtures/test-layout-expected.jsonso it participates in tooling and layout checks.Testing
bun test tests/codex-integration/native-profile-startup-publication.test.ts tests/codex-integration/native-profile-startup.test.ts tests/test-layout.test.ts tests/test-layout-tooling.test.tsand observed the changed/focused tests pass (66 passed, 0 failed).bun run typecheckandbun run privacy:scan, both reported success.bun run test; the new focused tests passed, but the full parallel suite produced unrelated timing/contention failures in preexisting tests (unrelated to these changes).Codex Task