Skip to content

fix(test): isolate sidebar browser debugging on a private pipe - #590

Open
luvs01 wants to merge 2 commits into
devfrom
codex/propose-fix-for-chrome-devtools-vulnerability
Open

luvs01 wants to merge 2 commits into
devfrom
codex/propose-fix-for-chrome-devtools-vulnerability

Conversation

@luvs01

@luvs01 luvs01 commented Sep 21, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The opt-in geometry regression harness previously launched Chrome with an unauthenticated loopback DevTools TCP listener, which exposes CDP to other local principals during the test window.

Description

  • Replace the loopback TCP DevTools transport with Chrome's process-private pipe by switching the harness to --remote-debugging-pipe and using a child-process pipe-based CDP transport.
  • Remove the DevToolsActivePort polling and HTTP /json target creation and instead create and attach a target via the pipe (Target.createTarget + Target.attachToTarget) and send/receive CDP frames over the private pipe.
  • Use node:child_process.spawn and pipe stdio for the private transport and harden cleanup of the temporary profile and browser process.
  • Add a regression assertion in gui/tests/sidebar-version-layout.test.ts that the opt-in harness contains --remote-debugging-pipe and does not include --remote-debugging-port or --remote-debugging-address.
  • Files changed: gui/tests/sidebar-version-browser.ts, gui/tests/sidebar-version-layout.test.ts.

Testing

  • Ran bun test tests/sidebar-version-layout.test.ts which passed (6 tests, 0 failures).
  • Ran bun run lint and bun run build in gui/ which completed successfully (build emitted an existing chunk-size advisory).
  • Ran bun run typecheck and bun run privacy:scan, both completed without introducing issues.
  • Built the harness script with bun build tests/sidebar-version-browser.ts --target=bun --outdir /tmp/ocx-browser-check which succeeded.
  • bun run test:sidebar-version could not be executed in this environment because Chrome/Chromium was not installed; the harness is not runnable here but the pipe-based transport is implemented and unit/regression checks confirm the change.
  • The full repository test run showed unrelated environment/tooling failures in this execution environment (package-pinned Bun/Jest integration issues), but focused layout and validation checks for this change are green.

Codex Task


Devin Review

devin-ai-integration Bot and others added 2 commits September 20, 2026 13:22
…forwarded role (lidge-jun#5334 follow-up)

lidge-jun#5334 made the developer wire role tri-state: an undeclared destination folds
it to system. Two suites asserting role:"developer" on the Chat wire were
missed because they are about tool-result repair ordering and document parts,
not role selection — declare the destination, per the convention the change
established.

Verified: both files fail on dev@600075d2 with system-for-developer wire roles
and pass with the declaration.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository: luvs01/opencodex/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: b5f1fb12-ba0c-405a-b1a8-921cee2d1bb7


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 21, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-21T01:16:35.642295Z 29a61c1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Sep 21, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant