Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 📝 WalkthroughWalkthroughAdds Bash and PowerShell helpers to send messages to Codex threads with ChangesComposer usage-gate fallback
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~12 minutes Change: Other Suggested reviewers: Merge Risk: 🟡 Moderate · up to The new fallback helpers can fail or send a message to the wrong conversation in the following cases:
The guide also slightly misdescribes which session 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
a1fe4fb to
b54342c
Compare
b54342c to
fbda967
Compare
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Require deliberate thread targeting, honor CODEX_HOME, probe queue-capable native CLIs, preserve literal arguments, and avoid retries or auth changes. Document that queue acceptance is not execution and add offline wrapper tests. Validation: 24 Bash regression tests, bash -n, node --check, and diff check. Windows/PowerShell, macOS, live Desktop dispatch, and repository-wide Bun/docs checks were not executed in this environment; no cross-platform pass claimed.
luvs01
left a comment
There was a problem hiding this comment.
Implemented the focused hardening in 45ff4f9; all four GitHub file blobs match the locally tested versions.
Assessment: native codex queue is a reasonable least-invasive fallback for an otherwise usable thread when preserving desktop authentication is important. It is not a complete composer/model-picker fix. In particular, a thread still configured for gpt-reserve is not rerouted by queueing, and server quotas/authorization remain unchanged.
The revision addresses the valid review findings: effective CODEX_HOME, supported standalone layouts, bundled-before-PATH capability selection, safe global latest-file selection without ls/head, Bash end-of-options, and resume --last working-directory scope. It additionally removes implicit target selection, adds preview/explicit binary pinning, preserves literal native arguments, and avoids automatic retry.
The most important documentation correction is acceptance versus dispatch: the inspected upstream run_session_queue_action_with_app_server sends thread/queue/add only, while dispatch_if_idle/wake_if_loaded do not load an absent thread. An accepted message can remain pending. The guide now says to inspect/open/resume the same conversation without submitting the prompt again. No automatic force-start or second-server workaround was introduced.
Executed here: 24/24 offline Bash wrapper tests with Node 22.16.0/Bash 5.2, bash -n, node --check, and diff whitespace validation. The tests use fake native CLIs, not an account/model. Windows PowerShell, macOS, actual Desktop/provider completion and remote-control continuity remain unverified. Full Bun checks/privacy/prepush and docs build were unavailable locally and remain explicitly unchecked in the PR description. At the latest observation, Cross-platform CI was in progress; this comment is not a merge approval or an assertion that all checks are green.
I have left the existing review threads available for reviewer re-evaluation rather than treating the new source changes as proof of unexecuted platform/runtime coverage.
Document the on-demand lifecycle, ordinary-usage behavior, existing routing ownership, and repository-only distribution. Preserve PowerShell's current filesystem directory for native CLI children and redact dry-run selection unless explicitly requested in a local terminal. Add sidebar discovery and an offline Windows/macOS/Linux wrapper workflow with read-only permissions. Validation: 32 Linux Bash offline tests, bash -n, Node syntax checks, YAML static security checks, and diff whitespace checks. Windows/macOS, live Desktop dispatch, and full Bun/docs validation remain separate checks.
| include: | ||
| - os: ubuntu-latest | ||
| shells: bash | ||
| - os: macos-latest | ||
| shells: /bin/bash | ||
| - os: windows-latest | ||
| shells: powershell.exe,pwsh.exe |
There was a problem hiding this comment.
There was a problem hiding this comment.
Exact-head wrapper evidence is now available for b8cfba1: Codex queue helpers run 35957767065 completed successfully for ubuntu-latest, macos-latest (/bin/bash), and windows-latest (required powershell.exe and pwsh.exe). This supersedes the first Windows failure; the follow-up fixed relative-home discovery and corrected 8.3-path/outer-launcher assertions without skipping tests. Local Linux has 33/33 passes.
I am deliberately keeping this thread unresolved as a remaining verification gate: the separate latest-head Cross-platform CI run 35957766946 was still queued at the last observation, local full Bun/prepush and docs builds were unavailable, and live Desktop/OpenCodex/remote-control verification is not established by fake-CLI tests. No merge or approval has been performed. The PR checklist also leaves independent maintainer review of the new read-only workflow outstanding.
There was a problem hiding this comment.
Exact-head platform evidence is now available for b8cfba1: Codex queue helpers run 35957767065 succeeded on Ubuntu, macOS and Windows, including the required Windows PowerShell 5.1 and PowerShell 7 harnesses. This is the current PATH-fix head, not just parent 59bf48c. Independently re-ran the exact published Linux harness: 33/33 passed after verifying the fetched file blob hashes.
The initial Windows failures at c938967 were real test results and were not skipped: 59bf48c corrected PowerShell 5.1 relative-home resolution, filesystem alias comparisons, and the outer PowerShell launcher's exit propagation. b8cfba1 additionally fixes later PATH-candidate discovery.
The separate general Cross-platform CI run 35957766946 was still queued/in progress at this check; local bun run prepush and the full local Bun/Astro checks have not been executed in this limited workspace. Independent workflow security review and live Desktop/OpenCodex dispatch/remote-control verification also remain outstanding. I am leaving this verification thread open rather than equating green offline wrapper tests with all merge/readiness requirements. No merge or approval is being performed.
The new Windows CI exposed a relative CODEX_HOME lookup failure in Windows PowerShell 5.1. Anchor filesystem discovery to the shell location while preserving the environment passed to Codex. Correct the offline harness to compare native canonical paths (8.3 aliases are not different directories) and propagate the script's LASTEXITCODE through the outer PowerShell -EncodedCommand launcher. No tests are skipped. Validation: 32 Linux offline tests and syntax checks pass. Windows and macOS will be verified by the required-shell workflow for this exact head.
Address the new bot finding without changing bundle-first or explicit-pin semantics. Inspect PATH entries in order and reject an obsolete candidate before trying the next one. Preserve whitespace in paths. Add an offline regression with two competing PATH executables. Linux suite: 33 passed, 0 failed; bash and Node syntax plus whitespace checks pass.
luvs01
left a comment
There was a problem hiding this comment.
Follow-up integration/lifecycle review completed for b8cfba1.
Assessment: preserve the native queue + existing OpenCodex routing boundary. This is a deliberately narrow on-demand fallback, not a fully packaged/dashboard-integrated feature or a model-picker repair. A persistent toggle would add state without controlling any background behavior, because no helper runs until explicitly invoked. Normal usage availability does not suppress a deliberate invocation: it queues one ordinary message. Stopping future invocations does not cancel already accepted queue items.
Changes in this follow-up: c938967 documents integration/on-off/normal-usage behavior, redacts default diagnostics, preserves PowerShell working-directory context, adds guide discovery, and wires a dedicated offline platform workflow. 59bf48c fixes the Windows PowerShell relative-home failure exposed by that CI and corrects the harness's 8.3-path/outer-launcher exit-code assertions. b8cfba1 fixes the newly reported later-PATH CLI discovery defect and adds its regression.
Observed verification: local Linux 33/33 offline tests; exact-head Codex queue helpers workflow 35957767065 completed successfully on Linux, macOS system Bash and Windows PowerShell 5.1/7. React Doctor 35957767006 succeeded. These use fake native CLIs and temporary configuration files, not real account/model traffic.
Bot handling: reviewed the 15 known inline threads, including follow-up findings. Five previously resolved Devin threads remain addressed; nine additional code/documentation/metadata threads have individual evidence-bearing replies and are resolved. The remaining pre-merge verification thread PRRT_kwDOTmCbas6lcVt7 has an explicit status reply and stays open. CodeRabbit independently confirmed the four original findings after the replies. No blanket bot approval or silent dismissal was used.
Outstanding: separate latest-head Cross-platform CI 35957766946 was queued at the last observation; local complete Bun/prepush/docs checks were unavailable; live Desktop→OpenCodex→provider completion and remote-control continuity remain unverified; the new read-only workflow still needs independent maintainer security review. No merge/approval, user-PC configuration change, daemon restart, quota manipulation or real model request was performed.
Summary
Use native
codex queueas an on-demand, limited fallback for a composer-only usage gate. Submit one message to an explicit existing thread without changing OpenCodex routing, ChatGPT authentication, account entitlements, app files, TLS or Statsig. This does not unlock the model picker, switch an existinggpt-reservethread to another provider, or reset quota. App/CLI updates can still change compatibility.Integration and on/off behavior
CODEX_HOME,OPENCODEX_HOME, working-directory context and both applications' configuration. Only thread and text are passed. On Windows, filesystem discovery and the native child use PowerShell's current location, including relative homes afterSet-Location.ocx restoreor disabling the normal integration.ocx queuecommand or dashboard control. The existing npm file allowlist excludesscripts/. No packaging/runtime feature is claimed or added.Implementation and bot follow-up
--show-target/-ShowTargetrequires dry run and local terminal output, with control-character escaping. Fixed helper errors avoid raw private filesystem exceptions. Native CLI output during a real submission is still passed through; terminal recording and process-argument visibility are not prevented.resume --lastdirectory filtering, and queue acceptance versus execution/completion..github/workflows/codex-queue-helpers.ymlruns Linux Bash, macOS system Bash, Windows PowerShell 5.1 and PowerShell 7. Required shells fail rather than silently skip. This is separate from live Desktop/provider/remote-control verification.Source basis: OpenAI Codex
7dae8c53d97e61cd774e4d6bcca5243c29ca615c(queue_cmd.rs,session_queue_commands.rs, queueservice.rs,ResumeCommand), current OpenCodex provider-target code, and package file allowlist. Source checks and fake-CLI tests are not live provider-routing evidence.Verification
Current head:
b8cfba17a0953d4fed9d5441c3adfe1ca7ba7872.CODEX_QUEUE_TEST_SHELLS=bash node --test scripts/codex-queue.test.mjs— 33 tests, 0 failures, Linux / Node 22.16.0 / Bash 5.2.git diff --checkin the partial validation workspace. Committed changed-file blob SHAs match the local tested files. All pushes preserve prior commits; no force push.contents: read, no secret use, pinned existing checkout action,persist-credentials: false, no dependency installation or real Codex/account/model calls. This is technical inspection, not independent maintainer approval.Still unverified: real matching Desktop queue dispatch through the intended OpenCodex provider and remote-control continuity. The original author-reported Windows desktop 26.917.9434.0 probe established queue acceptance, not a completed model turn.
The local workspace has no Bun, PowerShell or full checkout and could not retrieve dependencies. Therefore local
bun run typecheck,bun run test,bun run privacy:scan,bun run prepush, and the Astro install/build have not been run. Hosted Windows/macOS wrapper results are verified CI results but do not replace these unexecuted local commands or live integration verification.Checklist