chore!: drop TreeConverter - #79
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking.
TreeConverterandNewTreeConverterare removed.Convertis now the conversion itself rather than a wrapper around a package singleton.Since the
Converterinterface went in #70,TreeConverterhas been an empty struct. It had no state and one method, and existed only soConvertcould delegate to it. Everything per-document already lives on the unexportedconversion.Only callers of
NewTreeConverterbreak. Nothing in this repo used it apart from the rootBenchmarkTree, which is nowBenchmarkConvertand callsConvertdirectly.