fix: keep control characters in content from acting as markers - #81
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conversion marks blockquotes, list indents, horizontal rules and
<pre>blocks with the control characters\x00–\x06. The comment on those constants said the parser never emits control characters, but it does: raw ones pass through, and so do entities such as. Content containing them was read back as markup.Text and attribute values are now read through
withoutMarkers: text nodes, span text,<pre>text andgetAttr. It does a byte scan first and only rebuilds a string when a marker is present. Markers are ASCII, so the scan cannot match inside a multi-byte rune.I first tried a separate walk over the tree before conversion, but that cost about 3% and
strings.Mapon every string cost 8%. Reading throughwithoutMarkerscosts +1.6% geomean when run interleaved against main, and only pathological is outside noise at +2.3%. Allocations are unchanged.Output is byte-for-byte identical to main across the corpus under every link style.