feat: add ConvertReader for documents read from an io.Reader - #83
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConvertReader(r io.Reader, opts ...Option)converts a document straight from a reader.Convertnow wraps it with astrings.Reader.A mail pipeline usually has the HTML part as a reader, such as a MIME part or a decoded transfer encoding. Callers no longer need to read it into a string first, because
html.Parsealready consumes a reader.This also brings coverage to 100%. The
html.Parseerror return was the last uncovered statement, since astrings.Readernever fails, and now a failing reader reaches it.TestConvertReaderusesiotest.ErrReaderto check that read errors come back unchanged.The change is additive, and
Convert's signature and behaviour are the same. The README mentionsConvertReaderunder Usage.