Remove dead Banner cruft from views (#661)#1392
Merged
Merged
Conversation
The 2018 design that put banners on multiple page types (People, News, etc.) was never implemented — it only ever existed as commented-out Banner.PEOPLE / page= stubs plus now-unused Banner imports. Banners today render only on the landing page and one project page, so this code is dead. Removing it alongside closing #661 as obsolete. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #661 (closed as obsolete) by removing the dead code it leaves behind.
What & why
Issue #661 (2018) asked for banners on multiple pages/projects, built around an old admin
Page:dropdown that no longer exists. TheBannermodel was since refactored tolanding_page(boolean) + a singleprojectFK, and banners render only on the landing page and one project page.The "other page types" (People/News) design was never wired up — it survived only as dead stubs:
website/views/member.py— commentedBanner.objects.filter(page=Banner.PEOPLE)/displayed_bannerslines + the commented'banners'context entrywebsite/views/people.py— unusedBannerimportwebsite/views/news_listing.py— unusedBannerimportThis PR deletes all of it.
ml_utilsis kept inmember.py(still used elsewhere).Scope
No behavior change — purely removing commented/unused code. No model, template, or URL changes.
🤖 Generated with Claude Code