Flag publications missing an expected companion artifact (#1405)#1407
Merged
jonfroehlich merged 1 commit intoJun 26, 2026
Merged
Conversation
Add two Data Health checks (Artifacts group) for publications that should have a related artifact but don't: - Conference papers without a talk: Conference venue type, not an extended abstract, talk FK empty. Most full conference papers are presented with a talk, so these are usually data-entry gaps. - Poster papers without a linked poster: Poster venue type, poster FK empty. Both share CompanionArtifactCheck, which excludes pre-Makeability-Lab work (DATE_MAKEABILITYLAB_FORMED) and not-yet-presented (future-dated) papers to avoid permanent false positives, and links each row to the publication's edit page where the FK is set. Kept as two separate checks (distinct dashboard counts) because the corrective action differs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of #1405 (companion checks). Stacked on #1406 — base is
1405-data-health-action-links, so this diff is just the new checks. GitHub will auto-retarget tomasteronce #1406 merges.What & why
Some publication types almost always ship with a companion artifact, and the gaps were invisible. Two new Data Health checks (Artifacts group) surface them:
talkempty. Most full conference papers are presented with a talk, so these are usually data-entry gaps.posterempty (the poster won't show on the site).Kept as two separate checks (distinct dashboard counts) because the corrective action differs — add a talk vs. add a poster.
Scoping (avoids permanent false positives)
Shared
CompanionArtifactCheckbase excludes:DATE_MAKEABILITYLAB_FORMED, same convention as the unlinked-artifacts check) — grad-school-era papers predate the lab's talk/poster records.to_appear()) — the companion usually isn't recorded until the work is presented.Each row links to the publication's edit page, where the FK is set (via the
link_modelmechanism from #1406).Testing
python manage.py test website --settings=makeabilitylab.settings_test→ passing. Companion-check regression tests cover positive flagging plus every exclusion (talk present, extended abstract, to-appear, pre-lab, poster-with-poster, and cross-check isolation).🤖 Generated with Claude Code