Fix root-absolute /assets/movies gif paths (unblocks Jekyll 4)#118
Merged
Conversation
These 4 animation refs pointed at /assets/movies/ (root), but the files live in module asset folders (sensors/assets/movies, arduino/assets/movies). The old jekyll-relative-links bundled with the github-pages gem silently "rescued" them by resolving to the page's module folder; the newer jekyll-relative-links under Jekyll 4 (PR #117) does not, so html-proofer's link-check correctly flags them. Make the refs page-relative (assets/movies/...), which resolves correctly under both Jekyll 3.9.2 and 4. Surfaced by the html-proofer gate validating the Jekyll 4 upgrade. Part of #81 / #110. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jonfroehlich
added
the
content
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4 animation refs used root-absolute
/assets/movies/…but the files live in module asset folders. The oldjekyll-relative-links(github-pages gem) silently rescued them; the newer one under Jekyll 4 (#117) doesn't, so the html-prooferlink-checkgate flagged them. Page-relative paths resolve under both Jekyll 3.9.2 and 4.Surfaced by the link-check gate validating the Jekyll 4 upgrade (#117). Part of #81/#110.